Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]

Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]

[Michael Hoffman]

1. What exactly did you do?

- Execute:
(with-eval-after-load 'org
   (add-hook 'org-shiftleft-final-hook 'windmove-left))
(org-agenda nil "a")
(split-window-horizontally)

- Type S-left

2. What did you expect to happen?

(windmove-left)

3. What happened instead?

Received message "Command not allowed in this line"

Emacs  : GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
  of 2018-05-29
Package: Org mode version 9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)

current state:
==============
(setq
  org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-columns-default-format "\"%TODO %40FILE %30ITEM %20DEADLINE %1PRIORITY %ALLTAGS\""
  org-agenda-skip-scheduled-if-deadline-is-shown t
  org-metadown-hook '(org-babel-pop-to-session-maybe)
  org-agenda-tags-todo-honor-ignore-options t
  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
  org-refile-targets '((org-agenda-files :maxlevel . 3))
  org-agenda-files '("~/Dropbox/notes/todo.org" "~/Dropbox/org")
  org-shiftup-final-hook '(windmove-up)
  org-mode-hook '(#[0 "\300\301\302\303\304$\207"
                    [add-hook change-major-mode-hook org-show-block-all append local] 5]
                  #[0 "\300\301\302\303\304$\207"
                    [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                  org-babel-result-hide-spec org-babel-hide-all-hashes
                  guide-key/org-mode-hook-func)
  org-archive-hook '(org-attach-archive-delete-maybe)
  org-confirm-elisp-link-function 'yes-or-no-p
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-metaup-hook '(org-babel-load-in-session-maybe)
  org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
  org-shiftdown-final-hook '(windmove-down)
  org-babel-pre-tangle-hook '(save-buffer)
  org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
  org-shiftright-final-hook '(windmove-right)
  org-load-hook '(#[nil "\300\301\302\303#\210\300\304\302\305#\207"
                    [org-link-set-parameters "buffer" :follow org-buffer-open "term" org-term-open]
                    4]
                  )
  org-agenda-skip-deadline-prewarning-if-scheduled 'pre-scheduled
  org-ellipsis "▼"
  org-agenda-span 90
  org-tab-follows-link t
  org-confirm-shell-link-not-regexp "\\`thunderbird &\\'"
  org-occur-hook '(org-first-headline-recenter)
  org-lowest-priority 68
  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                   org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
  org-todo-keywords '((sequence "TODO(t)" "QUICK(q)" "WAITING(w)" "NEXT(n)" "STALL(s)" "|"
                       "DONE(d)" "CANCELLED(c)")
                      )
  org-support-shift-select 'always
  org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
  org-log-repeat nil
  org-default-priority 67
  org-shiftleft-final-hook '(windmove-left)
  org-return-follows-link t
  org-refile-use-outline-path t
  org-confirm-shell-link-function 'yes-or-no-p
  org-link-parameters '(("id" :follow org-id-open)
                        ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                        ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                        ("irc" :follow org-irc-visit :store org-irc-store-link)
                        ("info" :follow org-info-open :export org-info-export :store
                         org-info-store-link)
                        ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                        ("docview" :follow org-docview-open :export org-docview-export :store
                         org-docview-store-link)
                        ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                        ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
                         org-bbdb-complete-link :store org-bbdb-store-link)
                        ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                        ("doi" :follow org--open-doi-link) ("elisp" :follow org--open-elisp-link)
                        ("file" :complete org-file-complete-link)
                        ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path))))
                        ("help" :follow org--open-help-link)
                        ("http" :follow (lambda (path) (browse-url (concat "http:" path))))
                        ("https" :follow (lambda (path) (browse-url (concat "https:" path))))
                        ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path))))
                        ("news" :follow (lambda (path) (browse-url (concat "news:" path))))
                        ("shell" :follow org--open-shell-link))
  org-todo-keyword-faces '(("QUICK" :foreground "sienna" :weight bold))
  org-deadline-warning-days 0
  org-agenda-custom-commands '(("n" "Agenda and all TODO's" ((agenda "" nil) (alltodo "" nil)) nil)
                               ("d" "Quick TODOs with deadlines" todo "QUICK"
                                ((org-agenda-skip-function
                                  (function org-agenda-skip-if-notdeadline-inherit))
                                 )
                                )
                               ("D" "Quick TODOs with deadlines, disconnected" todo "QUICK"
                                ((org-agenda-skip-function
                                  (function org-agenda-skip-if-notdeadline-inherit))
                                 (org-agenda-tag-filter-preset (quote ("-internet" "-office"))))
                                )
                               ("q" "Quick TODOs" todo "QUICK"
                                ((org-agenda-skip-function
                                  (function org-agenda-skip-if-scheduled-future-inherit))
                                 )
                                )
                               ("p" "Projects" search "{^* }" ((org-agenda-overriding-header "")))
                               ("A" "Weekly agenda hiding scheduled items" agenda ""
                                ((org-agenda-skip-function
                                  (function org-agenda-skip-if-scheduled-future))
                                 )
                                )
                               )
  org-directory "~/notes"
  org-agenda-sorting-strategy '((agenda habit-down time-up priority-down category-keep)
                                (todo deadline-up priority-down category-keep)
                                (tags priority-down category-keep) (search category-keep))
  org-confirm-elisp-link-not-regexp "(org-agenda nil \"[qdA]\")"
  org-use-speed-commands t
  org-agenda-skip-deadline-if-done t
  org-agenda-todo-ignore-scheduled 'future
  org-default-notes-file "~/Dropbox/notes/todo.org"
  )

Re: Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]

[Nicolas Goaziou]

Hello,

Michael Hoffman <gmane4-hoffman@sneakemail.com> writes:

> 1. What exactly did you do?
>
> - Execute:
> (with-eval-after-load 'org
>   (add-hook 'org-shiftleft-final-hook 'windmove-left))
> (org-agenda nil "a")
> (split-window-horizontally)
>
> - Type S-left
>
> 2. What did you expect to happen?
>
> (windmove-left)
>
> 3. What happened instead?
>
> Received message "Command not allowed in this line"

That means one of the commands called by `org-shiftleft' failed.

Note that `org-shiftleft-final-hook' runs only when all other options
have been excluded, which is not the case here.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]

[Michael Hoffman]

On 2018-12-04 4:10 a.m., Nicolas Goaziou wrote:
> Michael Hoffman <gmane4-hoffman@sneakemail.com> writes:
>> 1. What exactly did you do?
>>
>> - Execute:
>> (with-eval-after-load 'org
>>    (add-hook 'org-shiftleft-final-hook 'windmove-left))
>> (org-agenda nil "a")
>> (split-window-horizontally)
>>
>> - Type S-left
>>
>> 2. What did you expect to happen?
>>
>> (windmove-left)
>>
>> 3. What happened instead?
>>
>> Received message "Command not allowed in this line"
> 
> That means one of the commands called by `org-shiftleft' failed.

Thanks for your response.

It does not appear that `org-shiftleft' is called at all in agenda buffers now. The `org-agenda-do-date-earlier'. C-h k S-left gives me:

```
<S-left> runs the command org-agenda-do-date-earlier (found in
org-agenda-mode-map), which is an interactive compiled Lisp function
in ‘org-agenda.el’.

It is bound to <S-left>, C-c C-x <left>, <menu-bar> <Agenda>
<Deadline/Schedule> <Change Time -1 hour>.

(org-agenda-do-date-earlier ARG)

Not documented.
```

`org-agenda.el' has `(org-defkey org-agenda-mode-map [(shift left)] 'org-agenda-do-date-earlier)` rather than a call to `org-shiftleft'.

I agree that the expected behavior would be for `org-shiftleft' to be called here and to call `org-agenda-do-date-earlier' when not overridden.

Michael

Re: Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]

[Michael Hoffman]

On 12/3/18 5:30 PM, Michael Hoffman wrote:
> 1. What exactly did you do?
> 
> - Execute:
> (with-eval-after-load 'org
>    (add-hook 'org-shiftleft-final-hook 'windmove-left))
> (org-agenda nil "a")
> (split-window-horizontally)
> 
> - Type S-left
> 
> 2. What did you expect to happen?
> 
> (windmove-left)
> 
> 3. What happened instead?
> 
> Received message "Command not allowed in this line"


Workaround:

(defvar org-agenda-mode-map)
(with-eval-after-load 'org-agenda
   (define-key org-agenda-mode-map [S-left] #'windmove-left)
   (define-key org-agenda-mode-map [S-right] #'windmove-right))

Michael Hoffman