From: Michael Hoffman <gmane4-hoffman@sneakemail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]
Date: Tue, 4 Dec 2018 16:43:22 -0500 [thread overview]
Message-ID: <pu6s9o$q97$1@blaine.gmane.org> (raw)
In-Reply-To: <87d0qhk68j.fsf@nicolasgoaziou.fr>
On 2018-12-04 4:10 a.m., Nicolas Goaziou wrote:
> Michael Hoffman <gmane4-hoffman@sneakemail.com> writes:
>> 1. What exactly did you do?
>>
>> - Execute:
>> (with-eval-after-load 'org
>> (add-hook 'org-shiftleft-final-hook 'windmove-left))
>> (org-agenda nil "a")
>> (split-window-horizontally)
>>
>> - Type S-left
>>
>> 2. What did you expect to happen?
>>
>> (windmove-left)
>>
>> 3. What happened instead?
>>
>> Received message "Command not allowed in this line"
>
> That means one of the commands called by `org-shiftleft' failed.
Thanks for your response.
It does not appear that `org-shiftleft' is called at all in agenda buffers now. The `org-agenda-do-date-earlier'. C-h k S-left gives me:
```
<S-left> runs the command org-agenda-do-date-earlier (found in
org-agenda-mode-map), which is an interactive compiled Lisp function
in ‘org-agenda.el’.
It is bound to <S-left>, C-c C-x <left>, <menu-bar> <Agenda>
<Deadline/Schedule> <Change Time -1 hour>.
(org-agenda-do-date-earlier ARG)
Not documented.
```
`org-agenda.el' has `(org-defkey org-agenda-mode-map [(shift left)] 'org-agenda-do-date-earlier)` rather than a call to `org-shiftleft'.
I agree that the expected behavior would be for `org-shiftleft' to be called here and to call `org-agenda-do-date-earlier' when not overridden.
Michael
next prev parent reply other threads:[~2018-12-04 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 22:30 Bug: org-agenda-do-date-earlier does not honor org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @ /home/mhoffman/.emacs.d/elpa/org-9.1.14/)] Michael Hoffman
2018-12-04 9:10 ` Nicolas Goaziou
2018-12-04 21:43 ` Michael Hoffman [this message]
2019-05-03 18:40 ` Michael Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pu6s9o$q97$1@blaine.gmane.org' \
--to=gmane4-hoffman@sneakemail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).