emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bastien <bzg@gnu.org>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers"
Date: Sun, 13 Sep 2020 21:25:27 +0200	[thread overview]
Message-ID: <87d02pfpi0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r1r5lj7e.fsf@gnu.org> (Bastien's message of "Sun, 13 Sep 2020 18:44:53 +0200")


Bastien <bzg@gnu.org> writes:

> I pushed a fix in master (755367f36) that should prevent the problem
> you are pointing too while fixing the problem the OP reported.

I think this is still sub-optimal.

`org-logbook-drawer-re' doesn't mean much, because it hard-codes
"LOGBOOK" whereas `org-log-into-drawer' could have an entire different
value, including nil. As long as users can add log notes elsewhere than
into "LOGBOOK" drawer, the check you implemented will not work reliably.

I think encrypted entries should be considered as read-only. You should
not be able to reschedule them, or add a note, as long as
`org-at-encrypted-entry-p' is non-nil. I don't think you can handle the
initial problem otherwise.

Nicolas Goaziou

      reply	other threads:[~2020-09-13 19:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  8:44 Revert "Fix encrypt/decrypt in presence of arbitrary drawers" Nicolas Goaziou
2020-09-13 16:44 ` Bastien
2020-09-13 19:25   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d02pfpi0.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).