From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6Pm2L0xyXl9pSwAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 19:26:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8EmDKUxyXl/ADQAAB5/wlQ (envelope-from ) for ; Sun, 13 Sep 2020 19:26:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3397F940539 for ; Sun, 13 Sep 2020 19:26:04 +0000 (UTC) Received: from localhost ([::1]:39036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXdR-0004XS-SJ for larch@yhetil.org; Sun, 13 Sep 2020 15:26:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXd0-0004X4-HQ for emacs-orgmode@gnu.org; Sun, 13 Sep 2020 15:25:34 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:59541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXcy-0007dM-IO; Sun, 13 Sep 2020 15:25:34 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 1F4D8100003; Sun, 13 Sep 2020 19:25:27 +0000 (UTC) From: Nicolas Goaziou To: Bastien Subject: Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers" References: <87d02qgj6u.fsf@nicolasgoaziou.fr> <87r1r5lj7e.fsf@gnu.org> Mail-Followup-To: Bastien , Org Mode List Date: Sun, 13 Sep 2020 21:25:27 +0200 In-Reply-To: <87r1r5lj7e.fsf@gnu.org> (Bastien's message of "Sun, 13 Sep 2020 18:44:53 +0200") Message-ID: <87d02pfpi0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=mail@nicolasgoaziou.fr; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 14:20:17 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode List Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: K5VAkCF/AVUv Hello, Bastien writes: > I pushed a fix in master (755367f36) that should prevent the problem > you are pointing too while fixing the problem the OP reported. I think this is still sub-optimal. `org-logbook-drawer-re' doesn't mean much, because it hard-codes "LOGBOOK" whereas `org-log-into-drawer' could have an entire different value, including nil. As long as users can add log notes elsewhere than into "LOGBOOK" drawer, the check you implemented will not work reliably. I think encrypted entries should be considered as read-only. You should not be able to reschedule them, or add a note, as long as `org-at-encrypted-entry-p' is non-nil. I don't think you can handle the initial problem otherwise. Regards, -- Nicolas Goaziou