From: Ihor Radchenko <yantar92@gmail.com>
To: "Kai von Fintel" <fintel@mit.edu>,
"Juan Manuel Macías" <maciaschain@posteo.net>
Cc: emacs-orgmode@gnu.org, maciaschain@posteo.net
Subject: Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists
Date: Sat, 23 Jul 2022 22:50:42 +0800 [thread overview]
Message-ID: <87czdvannh.fsf@localhost> (raw)
In-Reply-To: <4F8FB342-420C-4A76-833F-4186E027655B@mit.edu>
Kai von Fintel <fintel@mit.edu> writes:
>>> (defun org-latex--format-spec (info)
>>> "Create a format-spec for document meta-data.
>>> INFO is a plist used as a communication channel."
>>> (let ((language (let ((lang (plist-get info :language)))
>>> (or (cdr (assoc-string lang org-latex-babel-language-alist t))
>>> (nth 1 (assoc-string lang org-latex-polyglossia-language-alist t))
>>> lang))))
>>>
>>> This borks my latex exports.
> ...
> Thanks, Ihor. Your change fixed my issue.
>
> I do think that the code on lines 1864 and 1865 of =ox-latex.el= (https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864) should not use the old variable names. Since you’ve now defined the old variables in =org-compat.el=, my exports work, so I’m ok for the moment. But I don’t understand why they are still used in the definition of =org-latex--format-spec=.
>
> But of course I’m far from familiar with the org code base.
Hmm. You are actually right.
Juan, can you please take a look. It looks like you missed
"org-latex--format-spec" in the patch. It should use the new
org-latex-language-alist variable instead.
Best,
Ihor
next prev parent reply other threads:[~2022-07-23 14:50 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 15:28 [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists Juan Manuel Macías
2022-07-10 9:25 ` Ihor Radchenko
2022-07-14 12:34 ` Juan Manuel Macías
2022-07-14 15:12 ` Max Nikulin
2022-07-14 15:53 ` Juan Manuel Macías
2022-07-14 18:17 ` Juan Manuel Macías
2022-07-15 12:18 ` Max Nikulin
2022-07-15 14:36 ` Juan Manuel Macías
2022-07-17 9:55 ` Ihor Radchenko
2022-07-17 14:48 ` Juan Manuel Macías
2022-07-18 6:44 ` Ihor Radchenko
2022-07-18 10:32 ` Juan Manuel Macías
2022-07-18 11:01 ` Juan Manuel Macías
2022-07-18 15:37 ` Max Nikulin
2022-07-18 16:21 ` Juan Manuel Macías
2022-07-19 15:01 ` Juan Manuel Macías
2022-07-19 17:01 ` Max Nikulin
2022-07-19 19:31 ` Juan Manuel Macías
2022-07-20 16:12 ` Max Nikulin
2022-07-20 21:30 ` Juan Manuel Macías
2022-07-21 14:36 ` Max Nikulin
2022-07-21 15:39 ` Juan Manuel Macías
2022-07-22 12:16 ` Max Nikulin
2022-07-22 12:49 ` Juan Manuel Macías
2022-07-22 14:07 ` Juan Manuel Macías
2022-07-23 15:19 ` Max Nikulin
2022-07-23 17:15 ` Improvements in the default LaTeX preamble (was: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists) Juan Manuel Macías
2022-07-24 12:06 ` Improvements in the default LaTeX preamble: templates? " Juan Manuel Macías
2022-07-25 9:31 ` Ihor Radchenko
2022-07-25 10:45 ` Improvements in the default LaTeX preamble: templates? Juan Manuel Macías
2022-07-23 5:01 ` [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists Ihor Radchenko
2022-07-23 13:44 ` BUG " Kai von Fintel
2022-07-23 13:59 ` Ihor Radchenko
2022-07-23 14:07 ` Kai von Fintel
2022-07-23 14:22 ` Ihor Radchenko
2022-07-23 14:39 ` Kai von Fintel
2022-07-23 14:50 ` Ihor Radchenko [this message]
2022-07-23 15:53 ` Juan Manuel Macías
2022-07-24 7:15 ` Ihor Radchenko
2022-07-24 11:29 ` Juan Manuel Macías
2022-07-26 11:58 ` Ihor Radchenko
2022-07-26 16:19 ` Juan Manuel Macías
2022-07-28 12:36 ` Ihor Radchenko
2022-07-23 14:53 ` Juan Manuel Macías
2022-07-23 14:11 ` Juan Manuel Macías
2022-07-23 14:25 ` Ihor Radchenko
2022-07-23 15:29 ` Max Nikulin
2022-07-24 7:23 ` Ihor Radchenko
2022-07-10 10:51 ` Max Nikulin
2022-07-15 15:38 ` Juan Manuel Macías
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czdvannh.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=fintel@mit.edu \
--cc=maciaschain@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).