emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [Patch] org-protocol default template should be nil
@ 2010-09-01  0:15 Sebastian Rose
  2010-09-01  5:10 ` Richard Riley
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Sebastian Rose @ 2010-09-01  0:15 UTC (permalink / raw)
  To: Emacs-orgmode mailing list

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi Carsten,


this little patch fixes an issue Richard brought up.

We always used the "w" template as the default for `org-remember' and
also used it for `org-capture' for historical reasons.

Unfortunately, this breaks, if the user has no "w" template defined.

The patch below simply set's the custom variable
`org-protocol-default-template-key' to nil, so the interactive template
selection is used by default.  This works for both, remember an capture.

I will adjust the docs, once the patch is applied.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-protocol-default-template-key-nil.patch --]
[-- Type: text/x-diff, Size: 420 bytes --]

diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index 3f240fd..21f28e7 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -260,7 +260,7 @@ Here is an example:
   :group 'org-protocol
   :type '(alist))
 
-(defcustom org-protocol-default-template-key "w"
+(defcustom org-protocol-default-template-key nil
   "The default org-remember-templates key to use."
   :group 'org-protocol
   :type 'string)

[-- Attachment #3: Type: text/plain, Size: 24 bytes --]




Thanks,

  Sebastian

[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Patch] org-protocol default template should be nil
  2010-09-01  0:15 [Patch] org-protocol default template should be nil Sebastian Rose
@ 2010-09-01  5:10 ` Richard Riley
  2010-09-01  6:38   ` David Maus
  2010-09-02 14:46 ` [Accepted] " Bastien Guerry
  2010-09-02 14:51 ` [Patch] " Bastien
  2 siblings, 1 reply; 6+ messages in thread
From: Richard Riley @ 2010-09-01  5:10 UTC (permalink / raw)
  To: emacs-orgmode


I dont know if its related but something has broken the use of

,----
| org-default-notes-file is a variable defined in `org.el'.
| Its value is "refile.org"
| 
| Documentation:
| Default target for storing notes.
| Used as a fall back file for org-remember.el and org-capture.el, for
| templates that do not specify a target file.
`----

for me too. I tend not to specify a destination file in my templates and
instead refile at a later date (hence the variable above is set to refile.org).

Now I get a backtrace :-

,----
| Debugger entered--Lisp error: (error "Not enough arguments for format string")
|   format("^\\(\\*+\\)[ 	]+\\(?:\\(TODO\\|STARTED\\|WAITING\\|DONE\\|CANCELLED\\|REPORT\\|BUG\\|KNOWNCAUSE\\|FIXED\\)\\>\\)?\\(?:[ 	]*\\(\\[#.\\]\\)\\)?\\(?:[ 	]*\\(?:\\[[0-9%%/]+\\]\\)\\)?[ 	]*\\(%s\\)\\(?:[ 	]*\\(?:\\[[0-9%%/]+\\]\\)\\)?\\(?:[ 	]+\\(:[[:alnum:]_@#%:]+:\\)\\)?[ 	]*$" "Tasks To Refile")
|   org-capture-set-target-location()
|   org-capture(nil)
|   call-interactively(org-capture nil nil)
`----

As a side note it was a bit of a misnomer. Possibly the storage should
use a 'org-default-capture-file variable since "notes" have their own
distinct meaning.


regards

r.

(apologies if this is a double post).

Sebastian Rose <sebastian_rose@gmx.de> writes:

> Hi Carsten,
>
>
> this little patch fixes an issue Richard brought up.
>
> We always used the "w" template as the default for `org-remember' and
> also used it for `org-capture' for historical reasons.
>
> Unfortunately, this breaks, if the user has no "w" template defined.
>
> The patch below simply set's the custom variable
> `org-protocol-default-template-key' to nil, so the interactive template
> selection is used by default.  This works for both, remember an capture.
>
> I will adjust the docs, once the patch is applied.
>
>
>
>
> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
> index 3f240fd..21f28e7 100644
> --- a/lisp/org-protocol.el
> +++ b/lisp/org-protocol.el
> @@ -260,7 +260,7 @@ Here is an example:
>    :group 'org-protocol
>    :type '(alist))
>  
> -(defcustom org-protocol-default-template-key "w"
> +(defcustom org-protocol-default-template-key nil
>    "The default org-remember-templates key to use."
>    :group 'org-protocol
>    :type 'string)
>
>
>
>
>
> Thanks,
>
>   Sebastian
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: Re: [Patch] org-protocol default template should be nil
  2010-09-01  5:10 ` Richard Riley
@ 2010-09-01  6:38   ` David Maus
  0 siblings, 0 replies; 6+ messages in thread
From: David Maus @ 2010-09-01  6:38 UTC (permalink / raw)
  To: Richard Riley; +Cc: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]

Richard Riley wrote:
>Now I get a backtrace :-

>,----
>| Debugger entered--Lisp error: (error "Not enough arguments for format string")
>|   format("^\\(\\*+\\)[ 	]+\\(?:\\(TODO\\|STARTED\\|WAITING\\|DONE\\|CANCELLED\\|REPORT\\|BUG\\|KNOWNCAUSE\\|FIXED\\)\\>\\)?\\(?:[ 	]*\\(\\[#.\\]\\)\\)?\\(?:[ 	]*\\(?:\\[[0-9%%/]+\\]\\)\\)?[ 	]*\\(%s\\)\\(?:[ 	]*\\(?:\\[[0-9%%/]+\\]\\)\\)?\\(?:[ 	]+\\(:[[:alnum:]_@#%:]+:\\)\\)?[ 	]*$" "Tasks To Refile")
>|   org-capture-set-target-location()
>|   org-capture(nil)
>|   call-interactively(org-capture nil nil)
>`----

This one is fixed in master.

Best,
  -- David

--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Accepted] org-protocol default template should be nil
  2010-09-01  0:15 [Patch] org-protocol default template should be nil Sebastian Rose
  2010-09-01  5:10 ` Richard Riley
@ 2010-09-02 14:46 ` Bastien Guerry
  2010-09-02 14:51 ` [Patch] " Bastien
  2 siblings, 0 replies; 6+ messages in thread
From: Bastien Guerry @ 2010-09-02 14:46 UTC (permalink / raw)
  To: emacs-orgmode

Patch 249 (http://patchwork.newartisans.com/patch/249/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C878w3m2ua3.fsf%40gmx.de%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] org-protocol default template should be nil
> Date: Wed, 01 Sep 2010 05:15:48 -0000
> From: Sebastian Rose <sebastian_rose@gmx.de>
> X-Patchwork-Id: 249
> Message-Id: <878w3m2ua3.fsf@gmx.de>
> To: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>
> 
> Hi Carsten,
> 
> 
> this little patch fixes an issue Richard brought up.
> 
> We always used the "w" template as the default for `org-remember' and
> also used it for `org-capture' for historical reasons.
> 
> Unfortunately, this breaks, if the user has no "w" template defined.
> 
> The patch below simply set's the custom variable
> `org-protocol-default-template-key' to nil, so the interactive template
> selection is used by default.  This works for both, remember an capture.
> 
> I will adjust the docs, once the patch is applied.
> Thanks,
> 
>   Sebastian
> 
> 
> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
> index 3f240fd..21f28e7 100644
> --- a/lisp/org-protocol.el
> +++ b/lisp/org-protocol.el
> @@ -260,7 +260,7 @@ Here is an example:
>    :group 'org-protocol
>    :type '(alist))
>  
> -(defcustom org-protocol-default-template-key "w"
> +(defcustom org-protocol-default-template-key nil
>    "The default org-remember-templates key to use."
>    :group 'org-protocol
>    :type 'string)
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Patch] org-protocol default template should be nil
  2010-09-01  0:15 [Patch] org-protocol default template should be nil Sebastian Rose
  2010-09-01  5:10 ` Richard Riley
  2010-09-02 14:46 ` [Accepted] " Bastien Guerry
@ 2010-09-02 14:51 ` Bastien
  2010-09-02 23:53   ` Sebastian Rose
  2 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2010-09-02 14:51 UTC (permalink / raw)
  To: Sebastian Rose; +Cc: Emacs-orgmode mailing list

Sebastian Rose <sebastian_rose@gmx.de> writes:

> We always used the "w" template as the default for `org-remember' and
> also used it for `org-capture' for historical reasons.
>
> Unfortunately, this breaks, if the user has no "w" template defined.
>
> The patch below simply set's the custom variable

Applied, thanks!

> `org-protocol-default-template-key' to nil, so the interactive template
> selection is used by default.  This works for both, remember an capture.
>
> I will adjust the docs, once the patch is applied.

You can go ahead!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Patch] org-protocol default template should be nil
  2010-09-02 14:51 ` [Patch] " Bastien
@ 2010-09-02 23:53   ` Sebastian Rose
  0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Rose @ 2010-09-02 23:53 UTC (permalink / raw)
  To: Bastien; +Cc: Emacs-orgmode mailing list

Bastien <bastien.guerry@wikimedia.fr> writes:
> Sebastian Rose <sebastian_rose@gmx.de> writes:
>
>> We always used the "w" template as the default for `org-remember' and
>> also used it for `org-capture' for historical reasons.
>>
>> Unfortunately, this breaks, if the user has no "w" template defined.
>>
>> The patch below simply set's the custom variable
>
> Applied, thanks!
>
>> `org-protocol-default-template-key' to nil, so the interactive template
>> selection is used by default.  This works for both, remember an capture.
>>
>> I will adjust the docs, once the patch is applied.
>
> You can go ahead!


Done and thanks!


  Sebastian

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-02 23:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-01  0:15 [Patch] org-protocol default template should be nil Sebastian Rose
2010-09-01  5:10 ` Richard Riley
2010-09-01  6:38   ` David Maus
2010-09-02 14:46 ` [Accepted] " Bastien Guerry
2010-09-02 14:51 ` [Patch] " Bastien
2010-09-02 23:53   ` Sebastian Rose

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).