emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: commit 5ea0228 has problem opening big org-mode file
Date: Wed, 27 Nov 2013 14:23:16 -0500	[thread overview]
Message-ID: <87a9gp8x97.fsf@alphaville.bos.redhat.com> (raw)
In-Reply-To: 8761rdy8me.fsf@Rainer.invalid

Achim Gratz <Stromeko@nexgo.de> writes:

> Nick Dokos writes:
>> I pushed the fix to master. Thanks to York and Tom for all the help.
>
> I'm not sure this fix is complete.  It seems that when someone would
> manually enter org-mode (say, in a scratch buffer) Emacs could return to
> an entirely different mode upon executing org-reset.
>
>> | 2 unexpected results:
>> |    FAILED  test-ob/catches-all-references
>
> This one is the bug I reported earlier today.
>
>> |    FAILED  test-org-element/link-parser
>
> This on the other hand bisects to your commit.  Plus, the above
> explanation is the reason for the test fail.  I've pushed a fix
> (f2483ec) that hopefully has no other side-effects not covered by tests.
>

OK, thanks for that. I was rushing this morning and did a pattern match
on the test name and decided it couldn't be me: famous last words. And
to add insult to injury, I didn't check on failures without the patch.
Oy,vey...

However, with your patch there is the opposite side of the coin: if you
have a buffer in a mode derived from org (as in York's case), then doing
C-c C-c on the options line will reset the mode to org, not to the
derived one, right?

Nick

  reply	other threads:[~2013-11-27 19:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  3:55 commit 5ea0228 has problem opening big org-mode file York Zhao
2013-11-25  4:28 ` Nick Dokos
2013-11-25 16:57   ` Nick Dokos
2013-11-25 19:26     ` Thomas S. Dye
2013-11-25 22:39       ` York Zhao
2013-11-26  1:38         ` York Zhao
2013-11-26  4:29           ` Nick Dokos
2013-11-26  4:53             ` Nick Dokos
2013-11-27  2:26               ` York Zhao
2013-11-27  2:29               ` Thomas S. Dye
2013-11-27 14:27               ` Nick Dokos
2013-11-27 18:58                 ` Achim Gratz
2013-11-27 19:23                   ` Nick Dokos [this message]
2013-11-27 19:53                     ` Achim Gratz
2013-11-26 19:25           ` Achim Gratz
2013-11-27  1:46             ` York Zhao
2013-11-27  7:24               ` Achim Gratz
2013-11-28  0:17                 ` York Zhao
2013-11-28  7:25                   ` Achim Gratz
2013-11-29  3:58                     ` York Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9gp8x97.fsf@alphaville.bos.redhat.com \
    --to=ndokos@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).