From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: commit 5ea0228 has problem opening big org-mode file Date: Wed, 27 Nov 2013 14:23:16 -0500 Message-ID: <87a9gp8x97.fsf@alphaville.bos.redhat.com> References: <871u255cla.fsf@gmail.com> <878uwcbes9.fsf@alphaville.bos.redhat.com> <87pppn4wg2.fsf@gmail.com> <87li0b4vcd.fsf@gmail.com> <87k3ftly1x.fsf@gmail.com> <8761rdy8me.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlki3-0008Kc-H0 for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 14:23:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vlkhx-0003Qz-RK for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 14:23:39 -0500 Received: from plane.gmane.org ([80.91.229.3]:56186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlkhx-0003PS-KA for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 14:23:33 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Vlkhv-0003Ft-Sx for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 20:23:31 +0100 Received: from nat-pool-bos-t.redhat.com ([66.187.233.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Nov 2013 20:23:31 +0100 Received: from ndokos by nat-pool-bos-t.redhat.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Nov 2013 20:23:31 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Achim Gratz writes: > Nick Dokos writes: >> I pushed the fix to master. Thanks to York and Tom for all the help. > > I'm not sure this fix is complete. It seems that when someone would > manually enter org-mode (say, in a scratch buffer) Emacs could return to > an entirely different mode upon executing org-reset. > >> | 2 unexpected results: >> | FAILED test-ob/catches-all-references > > This one is the bug I reported earlier today. > >> | FAILED test-org-element/link-parser > > This on the other hand bisects to your commit. Plus, the above > explanation is the reason for the test fail. I've pushed a fix > (f2483ec) that hopefully has no other side-effects not covered by tests. > OK, thanks for that. I was rushing this morning and did a pattern match on the test name and decided it couldn't be me: famous last words. And to add insult to injury, I didn't check on failures without the patch. Oy,vey... However, with your patch there is the opposite side of the coin: if you have a buffer in a mode derived from org (as in York's case), then doing C-c C-c on the options line will reset the mode to org, not to the derived one, right? Nick