emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-orgmode@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs
Date: Tue, 23 Apr 2019 10:20:15 +0200	[thread overview]
Message-ID: <87a7ghw2tc.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100")

Hello,

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> The first is whether orgalist-mode couldn't use a custom
> indent-line-function instead of advising what may or may not be set to
> indent-relative by the user.

I don't know how that would work in practice. But a minor mode taking
control over `indent-line-function' sounds wrong.

> The second is why advice--buffer-local does what it does.  Stefan, why
> does it behave differently depending on local-variable-p?  Why can't it
> simply call make-local-variable before returning the symbol-value?
>
> The third is why indent-according-to-mode hard-codes the check for
> indent-relative and indent-relative-first-indent-point.  Wouldn't it be
> nice if this check instead looked up some variable akin to
> electric-indent-functions-without-reindent, that can be more easily
> customised?

So what is the current status of this? Do I still need to add
a workaround around a workaround around a genuine Emacs bug? :)

Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2019-04-23  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 16:35 orgalist-mode: wrong indentation in message mode after recent change in emacs Gregor Zattler
2019-04-01 22:32 ` Basil L. Contovounesios
2019-04-02 11:08   ` Stefan Monnier
2019-04-11 20:32   ` Stefan Monnier
2019-04-23  8:20   ` Nicolas Goaziou [this message]
2019-04-23 10:53     ` Basil L. Contovounesios
2019-04-23 12:15       ` Stefan Monnier
2019-12-31 10:30       ` Nicolas Goaziou
2019-04-12 21:10 ` Amin Bandali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7ghw2tc.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).