From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org
Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs
Date: Thu, 11 Apr 2019 16:32:50 -0400 [thread overview]
Message-ID: <jwva7gwxp6a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100")
> The third is why indent-according-to-mode hard-codes the check for
> indent-relative and indent-relative-first-indent-point. Wouldn't it be
> nice if this check instead looked up some variable akin to
> electric-indent-functions-without-reindent, that can be more easily
> customised?
Agreed. Comparing functions is always fraught with dangers, as we are
witnessing here (this very fundamental problem was arguably the original
motivation for inventing type-classes in Haskell to avoid the ugly
ad-hoc "eqtypes" of SML).
We need the comparison here for backward compatibility, but we should
supplement it with a variable, like we did with
`electric-indent-inhibit` (and not with
electric-indent-functions-without-reindent which just suffers from the
same fundamental problem).
Stefan
next prev parent reply other threads:[~2019-04-11 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 16:35 orgalist-mode: wrong indentation in message mode after recent change in emacs Gregor Zattler
2019-04-01 22:32 ` Basil L. Contovounesios
2019-04-02 11:08 ` Stefan Monnier
2019-04-11 20:32 ` Stefan Monnier [this message]
2019-04-23 8:20 ` Nicolas Goaziou
2019-04-23 10:53 ` Basil L. Contovounesios
2019-04-23 12:15 ` Stefan Monnier
2019-12-31 10:30 ` Nicolas Goaziou
2019-04-12 21:10 ` Amin Bandali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva7gwxp6a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).