From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Monnier Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Thu, 11 Apr 2019 16:32:50 -0400 Message-ID: References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sender: "Emacs-devel" To: "Basil L. Contovounesios" Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org List-Id: emacs-orgmode.gnu.org > The third is why indent-according-to-mode hard-codes the check for > indent-relative and indent-relative-first-indent-point. Wouldn't it be > nice if this check instead looked up some variable akin to > electric-indent-functions-without-reindent, that can be more easily > customised? Agreed. Comparing functions is always fraught with dangers, as we are witnessing here (this very fundamental problem was arguably the original motivation for inventing type-classes in Haskell to avoid the ugly ad-hoc "eqtypes" of SML). We need the comparison here for backward compatibility, but we should supplement it with a variable, like we did with `electric-indent-inhibit` (and not with electric-indent-functions-without-reindent which just suffers from the same fundamental problem). Stefan