From: Tim Cross <firstname.lastname@example.org>
Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x
Date: Thu, 05 Aug 2021 08:11:34 +1000 [thread overview]
Message-ID: <email@example.com> (raw)
Note that compatibility with 24.3 was not the cause of the OP original
issue (they were running 26.3).
Do we really want to maintain compatibility with Emacs 24.3? That
version was released over 8 years ago and I suspect there are other
areas of org which are not compatible with that version. Note also that
the subr-x and string-empty-p were introduced in Emacs 24.4. If we are
going to support Emacs 24, I think it is reasonable it be 24.4 rather
than aiming for all 24 releases.
I don't think this patch is required, especially since we have not had
any bug reported relating to that version.
Maxim Nikulin <firstname.lastname@example.org> writes:
> * lisp/org-agenda.el (org-agenda-highlight-todo): Do not use `string-empty-p'.
> Restore compatibility with Emacs-24.3.
> lisp/org-agenda.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index c3fbabc01..b6cd895bc 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7080,7 +7080,7 @@ The optional argument TYPE tells the agenda type."
> (setq x
> (substring x 0 (match-end 1))
> - (unless (string-empty-p org-agenda-todo-keyword-format)
> + (unless (string= org-agenda-todo-keyword-format "")
> (format org-agenda-todo-keyword-format
> (match-string 2 x)))
> ;; Remove `display' property as the icon could leak
next prev parent reply other threads:[~2021-08-04 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:24 Bug: org-agenda-highlight-todo: Symbol’s function definition is void: string-empty-p [9.4.6 (9.4.6-11-g1ee52c-elpa @ /home/vmg/.emacs.d/elpa/org-20210726/)] Вячеслав Гришин
2021-08-04 1:41 ` Tim Cross
2021-08-04 21:36 ` Вячеслав Гришин
2021-08-04 15:20 ` [PATCH] org-agenda.el: Avoid dependency on subr-x Maxim Nikulin
2021-08-04 21:41 ` Вячеслав Гришин
2021-08-05 17:04 ` Maxim Nikulin
2021-08-04 22:11 ` Tim Cross [this message]
2021-08-05 11:55 ` Maxim Nikulin
2021-08-05 12:59 ` Timothy
2021-08-06 17:10 ` Maxim Nikulin
2021-08-06 20:30 ` Timothy
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).