From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kHbEDLMRC2EJqQAAgWs5BA (envelope-from ) for ; Thu, 05 Aug 2021 00:16:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SOqhCLMRC2GRdgAA1q6Kng (envelope-from ) for ; Wed, 04 Aug 2021 22:16:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8C5B519BDD for ; Thu, 5 Aug 2021 00:16:18 +0200 (CEST) Received: from localhost ([::1]:60744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBPBQ-0002mp-HL for larch@yhetil.org; Wed, 04 Aug 2021 18:16:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBPAK-0002kW-Bv for emacs-orgmode@gnu.org; Wed, 04 Aug 2021 18:15:08 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:34427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBPAI-0007fk-0v for emacs-orgmode@gnu.org; Wed, 04 Aug 2021 18:15:08 -0400 Received: by mail-pl1-x630.google.com with SMTP id d1so4674713pll.1 for ; Wed, 04 Aug 2021 15:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version; bh=fkgmBo306hqsQ7NsGLPC8EJ4OXV0MU5URgqRZUUviTE=; b=QS+ekyiW90EKkepVlbE5K9Nv3Vofb5oAkP1SURMqOE2oAU2SZFpITRbizbdS3+IRvO PK3uGE+82ID/toovBqCS/yTndkCqwo09IyoQN6FoSg1qRgGiq53coEqBdcRz0uJAiRhg MCWvIA1UF8b5lsYXl02iqNTc+YtTOQdSht62nNNtx/dXjtQPJxZBZt3DCy4zQt7yF+pu VSLdnZlVLR1GohLJBaO7X8urZr8P3wjOGHBKHxwXfkKTV9TVmVtwq30F/B8H8YAwmw1Z 3FBOTj6pqD5COHexpDAv7y0spQ1DODKOgnONoR+kDSYysjpZZ4GLCN79aN88mNd36k0k z4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version; bh=fkgmBo306hqsQ7NsGLPC8EJ4OXV0MU5URgqRZUUviTE=; b=dLz25OqH4ksZxQCJrmoxuG7HafmXTQAx+RPwhMv2KoP2iaLQe/XQx49Y8VaoCb/Yze IB7hoKoufJmovrMs2lf9FhULdIX1voQcXCQ0PMvo7qdzCvrM+jkaykoVszZ7nBdf3p1B iPBcaiZyaK4o71OfmKNWZByMGg+vfzS+8fGKuE9WIXtptgj06FRD4amRRYFBYTItkXwT wakO6hk7FkychFuVFGTs9pyIsMqM6Schph8lvboMcG9THKLRvv6lVwvA4VUwXoi04cUb /bBpuoqgAboe2S1CPetF0SdwkAOLO8ihaDF4iQt/c8qZb8//+ZV0BKZhABJNDlrPIJ4p q8XA== X-Gm-Message-State: AOAM532X8oAjCYYdZwbZiJ7AIlMpcLkLm/HeusJwAPU0FdeakGKcxNgk 4zXwjNEBxWP+8ACBxUo84dVHBOT/CJc= X-Google-Smtp-Source: ABdhPJzXq44Iiqw081T1HktdpJarHayoMmarYxpzdwAgyZzU6NsxG1o6F3mSIKA7bv9CC35Q9oYUbQ== X-Received: by 2002:a17:90a:fd10:: with SMTP id cv16mr11702885pjb.134.1628115303679; Wed, 04 Aug 2021 15:15:03 -0700 (PDT) Received: from tim-desktop (220-235-13-134.dyn.iinet.net.au. [220.235.13.134]) by smtp.gmail.com with ESMTPSA id y2sm3696495pjl.6.2021.08.04.15.15.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 15:15:03 -0700 (PDT) References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> User-agent: mu4e 1.6.1; emacs 28.0.50 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x Date: Thu, 05 Aug 2021 08:11:34 +1000 In-reply-to: Message-ID: <87a6lwluvx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=theophilusx@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628115378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fkgmBo306hqsQ7NsGLPC8EJ4OXV0MU5URgqRZUUviTE=; b=HTmi1xJ1krXZegdqIP2NOETw04mN/hs15pNv7xqKbNVutaNAFQrDZTZ9/nUCfzQhkxt5zp ySTdtiltn4yT28Q/WYrIWv+ppie3vMCZ8A41pIgYHhpU28PEt50Sgcy4+lrAMs5C20Ej85 NlHwacvVPWwd3vxaDTqmuLqtmafrjPDYPpbrgrqu9XQQlOj3ILoj1TrBzLkMmQBzILEnsm HickBzay5zz3+dmB0Ca9Rc8bSwrHmjf0TXCsJISllUcBpJyZw554PuPdOea9QYDmidGuQQ LVD1gak2PXjDTFZbYuMQxeUDPwrTvigxq+F55MiSqbZX3pgRG8d9/UPCXYBWww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628115378; a=rsa-sha256; cv=none; b=V31oDe9X09QeYmSWT4VPK001sixrcpr+Xn9CqKvgjyTxTzqJPDg3PwIjHabWV21tAT6Ee6 yWKyZP6u/vDIKVIeQQiKMAWVK3WZHAied4UisoAhvhGbxfgrXGPB3f9eX/nl6eWWmRgDof EZDfmRUzM7JdB+P73z6OTscKoGlSy+PmIEzun3rgB4uhhAzfcXsJQg0ybhtHonwsIHP/n+ 8vyDH/6oR+E/hKDjvP/UBigNkkizc9K3OD+mMnbdwHa4gJqdwlwgbjCZ9F6La1pE9EOn3/ AbMdAgohuGhA5NO2OU+KjqgrHaYeifY+CdNaEDukQKHEk966LoU8zTCJp59/4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=QS+ekyiW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=QS+ekyiW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 8C5B519BDD X-Spam-Score: -3.11 X-Migadu-Scanner: scn1.migadu.com X-TUID: jHqj8sXoNqeG Note that compatibility with 24.3 was not the cause of the OP original issue (they were running 26.3). Do we really want to maintain compatibility with Emacs 24.3? That version was released over 8 years ago and I suspect there are other areas of org which are not compatible with that version. Note also that the subr-x and string-empty-p were introduced in Emacs 24.4. If we are going to support Emacs 24, I think it is reasonable it be 24.4 rather than aiming for all 24 releases. I don't think this patch is required, especially since we have not had any bug reported relating to that version. Maxim Nikulin writes: > * lisp/org-agenda.el (org-agenda-highlight-todo): Do not use `string-empty-p'. > > Restore compatibility with Emacs-24.3. > --- > lisp/org-agenda.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index c3fbabc01..b6cd895bc 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -7080,7 +7080,7 @@ The optional argument TYPE tells the agenda type." > (setq x > (concat > (substring x 0 (match-end 1)) > - (unless (string-empty-p org-agenda-todo-keyword-format) > + (unless (string= org-agenda-todo-keyword-format "") > (format org-agenda-todo-keyword-format > (match-string 2 x))) > ;; Remove `display' property as the icon could leak