Filtering agenda clockreport not working?

Filtering agenda clockreport not working?

[John Young]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hello,

In the org mode manual the description for org-agenda-clockreport-mode states that using a prefix argument when toggling this mode (i.e. typing “C-u R”) causes the clock table to exclude contributions to entries hidden by agenda filtering (as activated by typing “/“). I have tried this with a tags filter active, and the clock table is the same as when I don’t use a prefix argument. If I have clocked tasks tagged with a filtered out tag, they are still included in the agenda clock table.

I looked at the source code for the org-agenda-clockreport-mode function in org v9.5.4, and it appears that any prefix argument is ignored.

Am I misunderstanding something, or could this be a bug?

Many thanks for your help.

Best wishes,
John

[-- Attachment #2: Type: text/html, Size: 1051 bytes --]

Re: Filtering agenda clockreport not working?

[Ihor Radchenko]

John Young <jsy1001@cam.ac.uk> writes:

> In the org mode manual the description for org-agenda-clockreport-mode states that using a prefix argument when toggling this mode (i.e. typing “C-u R”) causes the clock table to exclude contributions to entries hidden by agenda filtering (as activated by typing “/“). I have tried this with a tags filter active, and the clock table is the same as when I don’t use a prefix argument. If I have clocked tasks tagged with a filtered out tag, they are still included in the agenda clock table.
>
> I looked at the source code for the org-agenda-clockreport-mode function in org v9.5.4, and it appears that any prefix argument is ignored.
>
> Am I misunderstanding something, or could this be a bug?

It looks like this functionality has been accidentally removed when
fixing some bug.

The culprit is

>> 2e9c2d7128e0491491d00b585be83ac688587d00
>> Author:     Bastien Guerry <bzg@altern.org>
>> AuthorDate: Thu Jun 12 15:07:35 2014 +0200
>> Commit:     Bastien Guerry <bzg@altern.org>
>> CommitDate: Thu Jun 12 15:07:35 2014 +0200
>> org-agenda.el: Fix bug when redoing sticky agendas with log mode and/or clockreport mode on
>> 
>> * org-agenda.el (org-agenda-mode): Let `org-agenda-redo' DTRT
>> when agenda are sticky.
>> (org-agenda-tag-filter-while-redo): Delete.
>> (org-agenda-list, org-agenda-redo, org-agenda-filter-by-tag):
>> Remove unused code.
>> (org-agenda-clockreport-mode, org-agenda-set-mode-name): Don't
>> consider tag filters.
>> 
>> Thanks to Bernt Hansen for reporting this.

Bastien, we usually do not remove the existing feature. Do you remember
if this was intentional, or should we reconsider that bugfix?

Given that relevant bug report only surfaced now, this feature may not
be something people are really relying upon. So, deleting the mention in
the manual might also be a valid option.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

Re: Filtering agenda clockreport not working?

[Ihor Radchenko]

Ihor Radchenko <yantar92@gmail.com> writes:

> It looks like this functionality has been accidentally removed when
> fixing some bug.
>
> The culprit is
>
>>> 2e9c2d7128e0491491d00b585be83ac688587d00
>>> Author:     Bastien Guerry <bzg@altern.org>
>>> AuthorDate: Thu Jun 12 15:07:35 2014 +0200
>>> Commit:     Bastien Guerry <bzg@altern.org>
>>> CommitDate: Thu Jun 12 15:07:35 2014 +0200
>>> org-agenda.el: Fix bug when redoing sticky agendas with log mode and/or clockreport mode on
>>> 
>>> * org-agenda.el (org-agenda-mode): Let `org-agenda-redo' DTRT
>>> when agenda are sticky.
>>> (org-agenda-tag-filter-while-redo): Delete.
>>> (org-agenda-list, org-agenda-redo, org-agenda-filter-by-tag):
>>> Remove unused code.
>>> (org-agenda-clockreport-mode, org-agenda-set-mode-name): Don't
>>> consider tag filters.
>>> 
>>> Thanks to Bernt Hansen for reporting this.

Confirmed.
This email is to track this bug report at updates.orgmode.org

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>