emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: John Young <jsy1001@cam.ac.uk>, Bastien <bzg@gnu.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Filtering agenda clockreport not working?
Date: Fri, 26 Aug 2022 21:20:50 +0800	[thread overview]
Message-ID: <87a67rxhsd.fsf@localhost> (raw)
In-Reply-To: <2a1b0eb3-c080-42dc-abc2-be84db5b5033@Spark>

John Young <jsy1001@cam.ac.uk> writes:

> In the org mode manual the description for org-agenda-clockreport-mode states that using a prefix argument when toggling this mode (i.e. typing “C-u R”) causes the clock table to exclude contributions to entries hidden by agenda filtering (as activated by typing “/“). I have tried this with a tags filter active, and the clock table is the same as when I don’t use a prefix argument. If I have clocked tasks tagged with a filtered out tag, they are still included in the agenda clock table.
> I looked at the source code for the org-agenda-clockreport-mode function in org v9.5.4, and it appears that any prefix argument is ignored.
> Am I misunderstanding something, or could this be a bug?

It looks like this functionality has been accidentally removed when
fixing some bug.

The culprit is

>> 2e9c2d7128e0491491d00b585be83ac688587d00
>> Author:     Bastien Guerry <bzg@altern.org>
>> AuthorDate: Thu Jun 12 15:07:35 2014 +0200
>> Commit:     Bastien Guerry <bzg@altern.org>
>> CommitDate: Thu Jun 12 15:07:35 2014 +0200
>> org-agenda.el: Fix bug when redoing sticky agendas with log mode and/or clockreport mode on
>> * org-agenda.el (org-agenda-mode): Let `org-agenda-redo' DTRT
>> when agenda are sticky.
>> (org-agenda-tag-filter-while-redo): Delete.
>> (org-agenda-list, org-agenda-redo, org-agenda-filter-by-tag):
>> Remove unused code.
>> (org-agenda-clockreport-mode, org-agenda-set-mode-name): Don't
>> consider tag filters.
>> Thanks to Bernt Hansen for reporting this.

Bastien, we usually do not remove the existing feature. Do you remember
if this was intentional, or should we reconsider that bugfix?

Given that relevant bug report only surfaced now, this feature may not
be something people are really relying upon. So, deleting the mention in
the manual might also be a valid option.

Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

  reply	other threads:[~2022-08-26 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9beec8b3-321b-43ee-931c-e735cc2c90fa@Spark>
2022-08-24 10:09 ` Filtering agenda clockreport not working? John Young
2022-08-26 13:20   ` Ihor Radchenko [this message]
2022-10-14  8:19     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a67rxhsd.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=jsy1001@cam.ac.uk \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).