Patch: hiding org emphasis markers

Patch: hiding org emphasis markers

[Tommy Phillips]

[-- Attachment #1.1: Type: text/plain, Size: 159 bytes --]

Hello,

Here is a suggested small patch for how org hides emphasis markers.
It's my first patch so hopefully I'm submitting it correctly.

All the best,
Tommy

[-- Attachment #1.2: Type: text/html, Size: 262 bytes --]

[-- Attachment #2: 0001-lisp-org.el-Only-hide-emphasis-markers-that-are-in-o.patch --]
[-- Type: application/octet-stream, Size: 1347 bytes --]

From e0ca6ad91afee63a015736026082937d97715418 Mon Sep 17 00:00:00 2001
From: Thomas Phillips <tphil98@gmail.com>
Date: Mon, 11 Sep 2023 19:02:50 +0100
Subject: [PATCH] lisp/org.el: Only hide-emphasis-markers that are in
 org-emphasis-alist

* lisp/org.el (org-do-emphasis-faces): Add additional predicate to the
  'and' clause that determines whether emphasis markers are hidden.

Problem:
Want to hide only the emphasis markers mentioned in org-emphasis-alist.
After removing "underline" from org-emphasis-alist, '_underline_' is not underlined (correct behaviour), but the '_'s are hidden (incorrect behaviour).

TINYCHANGE
---
 lisp/org.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 006f3688b..9ecf96c0d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5157,7 +5157,8 @@ stacked delimiters is N.  Escaping delimiters is not possible."
 	      (add-text-properties (match-beginning 2) (match-end 2)
 				   '(font-lock-multiline t org-emphasis t))
 	      (when (and org-hide-emphasis-markers
-			 (not (org-at-comment-p)))
+			 (not (org-at-comment-p))
+			 (assoc marker org-emphasis-alist))
 		(add-text-properties (match-end 4) (match-beginning 5)
 				     '(invisible t))
                 ;; https://orgmode.org/list/8b691a7f-6b62-d573-e5a8-80fac3dc9bc6@vodafonemail.de
-- 
2.38.1

Re: Patch: hiding org emphasis markers

[Ihor Radchenko]

Tommy Phillips <tphil98@gmail.com> writes:

> Here is a suggested small patch for how org hides emphasis markers.
> It's my first patch so hopefully I'm submitting it correctly.

The patch is ok. Thanks for submitting!

> Subject: [PATCH] lisp/org.el: Only hide-emphasis-markers that are in
>  org-emphasis-alist
>
> * lisp/org.el (org-do-emphasis-faces): Add additional predicate to the
>   'and' clause that determines whether emphasis markers are hidden.
>
> Problem:
> Want to hide only the emphasis markers mentioned in org-emphasis-alist.
> After removing "underline" from org-emphasis-alist, '_underline_' is not underlined (correct behaviour), but the '_'s are hidden (incorrect behaviour).

Currently, `org-emphasis-alist' works independently from `org-hide-emphasis-markers'.
Your patch will constitute a breaking change for users who removed
entries from `org-emphasis-alist', but still expect the markers to be
hidden.

You may instead introduce a new allowed value for
`org-hide-emphasis-markers' to hide markers for non-nil entries in
`org-emphasis-alist'. Maybe even allow the value to be an explicit list
of the markers to be hidden '("*" "_" ...).

And do note that the effect of `org-emphasis-alist' is purely visual -
Org still considers entries removed from the alist as markup. It is just
the display in Org buffers that is changed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Patch: hiding org emphasis markers

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> You may instead introduce a new allowed value for
> `org-hide-emphasis-markers' to hide markers for non-nil entries in
> `org-emphasis-alist'. Maybe even allow the value to be an explicit list
> of the markers to be hidden '("*" "_" ...).

One month have passed since the last activity in this thread.
Are you still interested to address the raised comments?
If you encounter any difficulties, feel free to ask us anything.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Patch: hiding org emphasis markers

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> You may instead introduce a new allowed value for
>> `org-hide-emphasis-markers' to hide markers for non-nil entries in
>> `org-emphasis-alist'. Maybe even allow the value to be an explicit list
>> of the markers to be hidden '("*" "_" ...).
>
> One month have passed since the last activity in this thread.
> Are you still interested to address the raised comments?
> If you encounter any difficulties, feel free to ask us anything.

No response.
Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>