emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Max Nikulin <manikulin@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: test-org-table/sort-lines: Failing test on macOS
Date: Mon, 06 Jan 2025 18:40:39 +0000	[thread overview]
Message-ID: <87a5c3hjko.fsf@localhost> (raw)
In-Reply-To: <CALn3zojOL5XrXkN+4Mbi-yvqGAhgVqK8=P59_0oY_XjyEm_mGg@mail.gmail.com>

Michael Brand <michael.ch.brand@gmail.com> writes:

> For this specific subject I can not see a follow up in this thread, or
> an implementation on the branches bugfix or main. And the complaint of
> the OP about the failing test is still valid on bugfix (on main ~make
> test~ aborted before with "void-variable (file)" on "(delete-file
> file)" quite early when loading testing/lisp/test-ob-tangle.el).

There was a transient problem on main. Now, make test should run.

This thread concluded with
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=413192698
(on main)

> As far as I understand and agree, some Org functionality wants to
> stick with ~string-collate-lessp~. Is it welcome if I finish working
> on my local patch that plans to use
>
> #+begin_src emacs-lisp
>   (defun org-test-string-collate-lessp-ignore-case-supported-p
>       (&optional locale)
>     "Whether `string-collate-lessp' supports ignore case for LOCALE.
>   According to the docstring of `string-collate-lessp' it does not
>   implement ignore case for some locale on some operating
>   systems (actually depending on libc of Emacs). E. g. on macOS
>   `string-collate-lessp' does not ignore case for the locale C.
>
>   See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59275 and
>   https://list.orgmode.org/orgmode/m2ilkwso8r.fsf@me.com"
>     (let ((ignore-case t))
>       (string-collate-lessp "a" "B" locale ignore-case)))
> #+end_src
>
> not to skip the test as suggested in the quote at the beginning of
> this message but to bifurcate the expected result of the ERT to fix
> the test for e. g. macOS on bugfix?

AFAIU, this is more complex. We cannot have a simple test for all
possible locales. Or did you find one? My conclusion from bug#59275
discussion is that simple tries like
(string-collate-lessp "a" "B" locale t)
will not work.
Especially for non-US locales.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2025-01-06 18:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 20:15 test-org-table/sort-lines: Failing test on macOS Rudolf Adamkovič
2022-10-07 12:04 ` Max Nikulin
2022-10-08  5:25   ` Ihor Radchenko
2022-10-08 14:27     ` Max Nikulin
2022-10-09  3:59       ` Ihor Radchenko
2022-10-09 15:38         ` Rudolf Adamkovič
2022-10-09 16:53           ` Max Nikulin
2022-10-10 22:25             ` Rudolf Adamkovič
2022-10-12 16:09               ` Max Nikulin
2022-11-15  4:10                 ` Ihor Radchenko
2022-11-20  4:18                   ` Ihor Radchenko
2022-11-20  8:00                     ` Max Nikulin
2022-11-21  3:15                       ` Ihor Radchenko
2022-11-21 16:48                         ` Max Nikulin
2022-11-22  1:14                           ` Ihor Radchenko
2022-11-22 16:01                             ` Max Nikulin
2022-11-23 10:37                               ` Ihor Radchenko
2022-11-23 15:27                                 ` Max Nikulin
2022-11-23 17:01                                   ` Max Nikulin
2022-11-26  2:05                                   ` Ihor Radchenko
2022-11-29 16:40                                     ` Max Nikulin
2024-04-03 11:40                                       ` [DISCUSSION] Sorting strings in Org mode vs. system locale (was: test-org-table/sort-lines: Failing test on macOS) Ihor Radchenko
2024-05-05 11:59                                         ` Ihor Radchenko
2024-05-07 11:06                                           ` [DISCUSSION] Sorting strings in Org mode vs. system locale Max Nikulin
2024-05-07 13:09                                             ` Ihor Radchenko
2024-05-07 16:47                                               ` Max Nikulin
2024-05-11  9:38                                                 ` Ihor Radchenko
2025-01-06 18:22                             ` test-org-table/sort-lines: Failing test on macOS Michael Brand
2025-01-06 18:40                               ` Ihor Radchenko [this message]
2025-01-06 20:49                                 ` Michael Brand
2025-01-08 16:49                                   ` Michael Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5c3hjko.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    --cc=michael.ch.brand@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).