emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Sam Ritchie <sritchie09@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix for ignored header args in org-babel-tangle
Date: Thu, 23 Apr 2015 21:55:01 +0200	[thread overview]
Message-ID: <878udi1uy2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <5532F914.5020505@gmail.com> (Sam Ritchie's message of "Sat, 18 Apr 2015 18:38:44 -0600")

Hello,

Sam Ritchie <sritchie09@gmail.com> writes:

> I found that all of my header arguments to source blocks were getting
> ignored. Moving the header-args into the let* binding seems to fix
> this issue, though I'm not enough of a guru to know why. Without this
> arguments like
>
> #+BEGIN_SRC clojure :tangle ./project.clj
>
> and
>
> #+BEGIN_SRC clojure :tangle no
>
> were getting ignored and substituted for ":tangle yes" along with
> other defaults.
>
> Hope this patch is in the right format:

Thank you. 

Would you mind providing your patch with "git format-patch" and follow
guidelines at

  http://orgmode.org/worg/org-contribute.html

for the commit message (e.g., you need to add TINYCHANGE at its end if
you didn't sign FSF papers yet).

Eventually, could you write a test for this? See
"testing/lisp/test-ob-tangle.el".


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-04-23 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19  0:38 [PATCH] fix for ignored header args in org-babel-tangle Sam Ritchie
2015-04-23 19:55 ` Nicolas Goaziou [this message]
2015-04-24  1:45   ` Charles C. Berry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878udi1uy2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=sritchie09@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).