From: "Charles C. Berry" <ccberry@ucsd.edu>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Sam Ritchie <sritchie09@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix for ignored header args in org-babel-tangle
Date: Thu, 23 Apr 2015 18:45:12 -0700 [thread overview]
Message-ID: <alpine.OSX.2.00.1504231820260.2080@charles-berrys-macbook.local> (raw)
In-Reply-To: <878udi1uy2.fsf@nicolasgoaziou.fr>
On Thu, 23 Apr 2015, Nicolas Goaziou wrote:
> Hello,
>
> Sam Ritchie <sritchie09@gmail.com> writes:
>
>> I found that all of my header arguments to source blocks were getting
>> ignored. Moving the header-args into the let* binding seems to fix
>> this issue, though I'm not enough of a guru to know why. Without this
>> arguments like
>>
>> #+BEGIN_SRC clojure :tangle ./project.clj
>>
>> and
>>
>> #+BEGIN_SRC clojure :tangle no
>>
>> were getting ignored and substituted for ":tangle yes" along with
>> other defaults.
>>
>> Hope this patch is in the right format:
I think it is inverted w.r.t. '-' vs '+'
>
> Thank you.
The patch in question modifies `org-babel-parse-src-block-match', which is
a central part of org-babel.
The patch looks innocuous, but I have a hard time believing that `:tangle
no' is ignored - there are many places I use it.
And if header args were ignored, lots of other things would break, too.
>
> Would you mind providing your patch with "git format-patch" and follow
Maybe start with an ECM?
Chuck
prev parent reply other threads:[~2015-04-24 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 0:38 [PATCH] fix for ignored header args in org-babel-tangle Sam Ritchie
2015-04-23 19:55 ` Nicolas Goaziou
2015-04-24 1:45 ` Charles C. Berry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1504231820260.2080@charles-berrys-macbook.local \
--to=ccberry@ucsd.edu \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=sritchie09@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).