Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Gustavo Barros]

Hi All,

As of recently, repeating tasks are no longer showing up in the agenda 
for future dates. Below a minimal example of the issue:

Start "emacs -Q" and do some setup:

#+begin_src emacs-lisp
(package-initialize)
(setq org-agenda-files '("~/test/agenda.org"))
#+end_src

Where "~/test/agenda.org" contains:

#+begin_src org
,* TODO weekly task
SCHEDULED: <2020-02-29 Sat +1w>
#+end_src

Open the agenda: "M-x org-agenda RET a", navigate for future dates and 
notice only the first instance of the repeating task is shown.

I can narrow the emergence of the problem between the following 
org-plus-contrib versions.

Latest working: Org mode version 9.3.2 (9.3.2-8-g47b104-elpaplus @ 
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20200127/)

First non-working: Org mode version 9.3.2 (9.3.2-24-g5c72d6-elpaplus @ 
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20200203/)


Best,
Gustavo.




Emacs  : GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 
3.22.30)
 of 2019-11-11
Package: Org mode version 9.3.6 (9.3.6-17-g389288-elpaplus @ 
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-agenda-files '("~/test/agenda.org")
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-show-all append 
		   local]
		   5]
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook 
		   org-babel-show-result-all
		    append local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes
		 org-eldoc-load)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 
 "\n\n(fn ENTRY)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
 org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" 
 . php)
		      ("C" . c) ("C++" . c++) ("asymptote" . asy)
		      ("bash" . sh) ("beamer" . latex) ("calc" 
		      . fundamental)
		      ("cpp" . c++) ("ditaa" . artist) ("dot" 
		      . fundamental)
		      ("elisp" . emacs-lisp) ("ocaml" . tuareg)
		      ("screen" . shell-script) ("shell" . sh)
		      ("sqlite" . sql))
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees 
 org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate
			  org-babel-speed-command-activate)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link 
 :export
			org-attach-export-link :complete
			org-attach-complete-link)
		       ("id" :follow org-id-open)
		       ("eww" :follow eww :store org-eww-store-link)
		       ("rmail" :follow org-rmail-open :store
			org-rmail-store-link)
		       ("mhe" :follow org-mhe-open :store 
		       org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store 
		       org-irc-store-link
			:export org-irc-export)
		       ("info" :follow org-info-open :export 
		       org-info-export
			:store org-info-store-link)
		       ("gnus" :follow org-gnus-open :store
			org-gnus-store-link)
		       ("docview" :follow org-docview-open :export
			org-docview-export :store 
			org-docview-store-link)
		       ("bibtex" :follow org-bibtex-open :store
			org-bibtex-store-link)
		       ("bbdb" :follow org-bbdb-open :export 
		       org-bbdb-export
			:complete org-bbdb-complete-link :store
			org-bbdb-store-link)
		       ("w3m" :store org-w3m-store-link)
		       ("elfeed" :follow elfeed-link-open :store
			elfeed-link-store-link)
		       ("file+sys") ("file+emacs")
		       ("shell" :follow org-link--open-shell)
		       ("news" :follow
			#[257 "\301\300\302Q!\207" ["news" browse-url 
                         ":"] 5
			  "\n\n(fn URL)"]
			)
		       ("mailto" :follow
			#[257 "\301\300\302Q!\207" ["mailto" browse-url 
                         ":"]
			  5 "\n\n(fn URL)"]
			)
		       ("https" :follow
			#[257 "\301\300\302Q!\207" ["https" browse-url 
                         ":"]
			  5 "\n\n(fn URL)"]
			)
		       ("http" :follow
			#[257 "\301\300\302Q!\207" ["http" browse-url 
                         ":"] 5
			  "\n\n(fn URL)"]
			)
		       ("ftp" :follow
			#[257 "\301\300\302Q!\207" ["ftp" browse-url 
                         ":"] 5
			  "\n\n(fn URL)"]
			)
		       ("help" :follow org-link--open-help)
		       ("file" :complete org-link-complete-file)
		       ("elisp" :follow org-link--open-elisp)
		       ("doi" :follow org-link--open-doi))
 org-link-elisp-confirm-function 'yes-or-no-p
 )

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Kyle Meyer]

Hi Gustavo,

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> Hi All,
>
> As of recently, repeating tasks are no longer showing up in the agenda 
> for future dates. Below a minimal example of the issue:

Thanks for the report and the minimal example to trigger the issue.
This bisects to 39c656870 (org-agenda.el: Fix handling of one-time
delays, 2020-02-01), which was part of the 9.3.3 release.  I believe
this is the thread that prompted that change:

  https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00353.html

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Gustavo Barros]

Hi all,

I'd like to respectfully bump this bug report.
It's an annoying regression of a widely used Org feature, is precisely 
located (to the commit) and has been reproduced by Kyle (btw, thanks, 
Kyle).
Of course, if someone is already looking into it, and just didn't have 
the time yet, please disregard the bump.

Best,
Gustavo.

On Fri, Feb 28 2020, Kyle Meyer wrote:

> Hi Gustavo,
>
> Gustavo Barros <gusbrs.2016@gmail.com> writes:
>
>> Hi All,
>>
>> As of recently, repeating tasks are no longer showing up in the 
>> agenda 
>> for future dates. Below a minimal example of the issue:
>
> Thanks for the report and the minimal example to trigger the issue.
> This bisects to 39c656870 (org-agenda.el: Fix handling of one-time
> delays, 2020-02-01), which was part of the 9.3.3 release.  I believe
> this is the thread that prompted that change:
>
>   https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00353.html

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Kyle Meyer]

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> I'd like to respectfully bump this bug report.
> It's an annoying regression of a widely used Org feature, is precisely 
> located (to the commit) and has been reproduced by Kyle (btw, thanks, 
> Kyle).
> Of course, if someone is already looking into it, and just didn't have 
> the time yet, please disregard the bump.

I've sat down to work on it a few times and wasn't able to get anywhere
with the time I had available.  It's on my list to revisit.  However, as
we have no proposed fix, in my view it'd make sense to revert the
problematic commit, 39c656870.  While that recent commit may resolve a
longstanding bug in the handling of one-time delays, it causes a
regression in functionality that I suspect is much more widely used and
relied on.

I'll plan to revert the commit tomorrow.  Please chime in if you
disagree with me doing so.

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Kyle Meyer]

Kyle Meyer <kyle@kyleam.com> writes:

> I've sat down to work on it a few times and wasn't able to get anywhere
> with the time I had available.  It's on my list to revisit.  However, as
> we have no proposed fix, in my view it'd make sense to revert the
> problematic commit, 39c656870.  While that recent commit may resolve a
> longstanding bug in the handling of one-time delays, it causes a
> regression in functionality that I suspect is much more widely used and
> relied on.
>
> I'll plan to revert the commit tomorrow.  Please chime in if you
> disagree with me doing so.

Reverted in 1de7eabf2.

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Gustavo Barros]

Hi Kyle,

On Sun, Apr 12 2020, Kyle Meyer wrote:

>> I'll plan to revert the commit tomorrow.  Please chime in if you
>> disagree with me doing so.
>
> Reverted in 1de7eabf2.

Thank you very much for this. I've already received the weekly build, 
and it looks good again.
Hopefully a solution for the one-time delay issue which does not trigger 
this new problem can be found.  But I concur (if I may) it was a wise 
decision to revert the commit in the meantime.

Best,
Gustavo.

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Bastien via General discussions about Org-mode.]

Hi Gustavo,

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> Hopefully a solution for the one-time delay issue which does not
> trigger this new problem can be found.  But I concur (if I may) it was
> a wise decision to revert the commit in the meantime.

Agreed, thanks Kyle.  I'll revisit the one-time delay issue later on,
and submit possible solutions before committing them.

-- 
 Bastien

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Bastien]

Hi Gustavo,

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> As of recently, repeating tasks are no longer showing up in the agenda 
> for future dates. Below a minimal example of the issue:

Just confirming this issue, to make sure we don't forget it.

-- 
 Bastien

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Gustavo Barros]

Hi Bastien,

On Thu, 10 Sep 2020 at 02:34, Bastien <bzg@gnu.org> wrote:

> Hi Gustavo,
>
> Gustavo Barros <gusbrs.2016@gmail.com> writes:
>
>> As of recently, repeating tasks are no longer showing up in the 
>> agenda 
>> for future dates. Below a minimal example of the issue:
>
> Just confirming this issue, to make sure we don't forget it.

Thank you for keeping track of this.  But this issue is currently not 
affecting us any longer.

If I recall correctly, the problem had emerged after a fix to another 
issue.  Kyle was able to identify the commit, and the discussion then 
converged to revert that commit, thus restoring the behavior which 
prompted this report of mine, until a fix for the other issue which did 
not cause this could be found.

Some of the relevant messages are:

- Kyle's message stating the commit was reverted, with the corresponding 
  commit numbers: https://orgmode.org/list/87o8rx1cmf.fsf@kyleam.com/

- The issue whose fix caused this regression is mentioned at: 
  https://orgmode.org/list/87o8tim83q.fsf@kyleam.com/

I think (not sure) that that issue is still pending.

Best,
Gustavo.

Re: Bug: Repeating tasks no longer appearing on future dates in the agenda [9.3.6 (9.3.6-17-g389288-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200224/)]

[Bastien]

Hi Gustavo,

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> Thank you for keeping track of this.  But this issue is currently not
> affecting us any longer.

... and thanks for double-checking this.

> Some of the relevant messages are:
>
> - Kyle's message stating the commit was reverted, with the
>   corresponding   commit numbers:
>  https://orgmode.org/list/87o8rx1cmf.fsf@kyleam.com/
>
> - The issue whose fix caused this regression is mentioned at:
>   https://orgmode.org/list/87o8tim83q.fsf@kyleam.com/
>
> I think (not sure) that that issue is still pending.

It is still pending, I will mark it as pending - thanks!

-- 
 Bastien