From: Kyle Meyer <kyle@kyleam.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo
Date: Thu, 16 Apr 2020 02:41:45 +0000 [thread overview]
Message-ID: <878siww3rq.fsf@kyleam.com> (raw)
In-Reply-To: <875zfrtw6m.fsf@alphapapa.net>
Adam Porter <adam@alphapapa.net> writes:
> Kaushal Modi <kaushal.modi@gmail.com> writes:
>
>> Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS
>>
>> Compiling ox-hugo.el now gives:
>>
>> ox-hugo.el:4284:1: Warning: the function ‘org-get-outline-path’ is not known to be defined.
>>
>> I see that defun has now moved to org-refile.el. I see that
>> org-get-outline-path has nothing to do specific to refiling. Can that
>> be moved back to org.el, or may be a separate library? Otherwise,
>> ox-hugo.el will have to load org-refile.el too (yes, I don't use
>> org-refile (yet), and that's how I discovered this :))
>
> Yes, please move that function back. This is going to cause breakage in
> a variety of packages that use that function but do not load
> org-refile. I can hear the bug reports rumbling already... ;)
Despite being sympathetic to any attempt to break up org.el, I agree
that it'd be good to move the outline path functionality back. Also,
there are a number of loading issues related to the org-refile move,
which can be seen by running `make single'.
I've prepared a commit that resolves these issues, which includes moving
org-get-outline-path and friends back to org.el, on the km/refile-fixups
branch:
https://code.orgmode.org/bzg/org-mode/commit/18e58aa0d7fd367b3506891b633a493f402e9fee
(It's not very useful to post it as a patch here because most of it's
code movement that's better viewed with git-diff's --color-moved.)
next prev parent reply other threads:[~2020-04-16 2:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:00 Debugging at least 2 regressions in org-mode master breaking ox-hugo Kaushal Modi
2020-02-27 14:13 ` Kaushal Modi
2020-02-27 14:19 ` Kaushal Modi
2020-09-06 21:37 ` Bastien
2020-09-07 11:47 ` Kaushal Modi
2020-02-28 0:03 ` Adam Porter
2020-03-05 13:49 ` Kaushal Modi
2020-03-05 14:04 ` Bastien
2020-03-05 14:43 ` Kaushal Modi
2020-04-16 2:41 ` Kyle Meyer [this message]
2020-04-24 10:53 ` Daniel Kraus
2020-04-25 1:34 ` Kyle Meyer
2020-04-26 5:31 ` Kyle Meyer
2020-04-28 17:21 ` Bastien
2020-05-21 7:03 ` Bastien
2020-04-24 11:20 ` Carsten Dominik
2020-05-11 14:10 ` Carsten Dominik
2020-05-11 14:27 ` Kyle Meyer
2020-05-11 14:48 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878siww3rq.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).