emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Carsten Dominik <dominik@uva.nl>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo
Date: Mon, 11 May 2020 16:10:40 +0200	[thread overview]
Message-ID: <CADn3Z2J5M-yFK8MPei_Wiew4vY5Kn1V0+_TPiSFYJ32zG1pwJA@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY1VR5t_a=JO01+QWbUQk_9i8+2XG6W2-mg-DpFzjz9seg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2111 bytes --]

Hi everyone,

I just tried to archive something and hit again the issue that
org-get-outline-paths undefined.  Is there a specific holdup why this
function has not been moved back into org.el?

Thanks

Carsten


On Thu, Feb 27, 2020 at 3:02 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> Hello,
>
> I recently updated to the latest org-mode master and it is failing
> ox-hugo[1] build and tests at 2 places.
>
> Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS
>
> Compiling ox-hugo.el now gives:
>
> ox-hugo.el:4284:1: Warning: the function ‘org-get-outline-path’ is not
> known to be defined.
>
> I see that defun has now moved to org-refile.el. I see that
> org-get-outline-path has nothing to do specific to refiling. Can that be
> moved back to org.el, or may be a separate library? Otherwise, ox-hugo.el
> will have to load org-refile.el too (yes, I don't use org-refile (yet), and
> that's how I discovered this :))
>
> Failure 2: Change in parsing of org babel header arguments.
>
> This was caught by my weekly Travis CI cron jobs for ox-hugo:
> https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#L2426
>
> 26c26
> < {{< highlight emacs-lisp "hl_lines=1" >}}
> ---
> > {{< highlight emacs-lisp "hl_lines=1 3-5" >}}
>
> Earlier this kind of src block header:
>
> #+begin_src emacs-lisp :hl_lines 1,3-5
> ...
> #+end_src
>
> got exported as
>
> {{< highlight emacs-lisp "hl_lines=1 3-5" >}}
>
> The regression is that now it is getting exported as
>
> {{< highlight emacs-lisp "hl_lines=1" >}}
>
> The values that I have after the comma in ":hl_lines 1,3-5" are getting
> lost.
>
> The relevant snippet where I parse the header arguments in ox-hugo.el is
> at
> https://github.com/kaushalmodi/ox-hugo/blob/f8ec4aa5ad7d92f94bd8dbb814d85f980be67aea/ox-hugo.el#L2563
>
> This behavior change in org-babel-parse-header-arguments is also not
> documented in ORG-NEWS. I will now investigate what cause this regression.
>
> ...
>
> --
> Kaushal Modi
>
> [1]: https://github.com/kaushalmodi/ox-hugo
>

[-- Attachment #2: Type: text/html, Size: 3316 bytes --]

next prev parent reply	other threads:[~2020-05-11 14:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 14:00 Debugging at least 2 regressions in org-mode master breaking ox-hugo Kaushal Modi
2020-02-27 14:13 ` Kaushal Modi
2020-02-27 14:19   ` Kaushal Modi
2020-09-06 21:37     ` Bastien
2020-09-07 11:47       ` Kaushal Modi
2020-02-28  0:03 ` Adam Porter
2020-03-05 13:49   ` Kaushal Modi
2020-03-05 14:04     ` Bastien
2020-03-05 14:43       ` Kaushal Modi
2020-04-16  2:41   ` Kyle Meyer
2020-04-24 10:53     ` Daniel Kraus
2020-04-25  1:34       ` Kyle Meyer
2020-04-26  5:31         ` Kyle Meyer
2020-04-28 17:21           ` Bastien
2020-05-21  7:03         ` Bastien
2020-04-24 11:20   ` Carsten Dominik
2020-05-11 14:10 ` Carsten Dominik [this message]
2020-05-11 14:27   ` Kyle Meyer
2020-05-11 14:48     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADn3Z2J5M-yFK8MPei_Wiew4vY5Kn1V0+_TPiSFYJ32zG1pwJA@mail.gmail.com \
    --to=dominik@uva.nl \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).