From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mLRnI5leuV4fTwAA0tVLHw (envelope-from ) for ; Mon, 11 May 2020 14:18:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UOIaIadeuV6KPQAA1q6Kng (envelope-from ) for ; Mon, 11 May 2020 14:18:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 358F6940BFF for ; Mon, 11 May 2020 14:18:13 +0000 (UTC) Received: from localhost ([::1]:42182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jY9G1-0000VN-VM for larch@yhetil.org; Mon, 11 May 2020 10:18:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY993-0008C4-8h for emacs-orgmode@gnu.org; Mon, 11 May 2020 10:11:01 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jY991-0003kg-CW for emacs-orgmode@gnu.org; Mon, 11 May 2020 10:11:00 -0400 Received: by mail-wr1-f67.google.com with SMTP id j5so11164810wrq.2 for ; Mon, 11 May 2020 07:10:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+iahpxXsSRM8dODgJEs0T8sI/hFMRTJ03g3Sx+3G4nw=; b=WU2WH8u9bEao9icU8Hs5RTxIHif1SfWHQbq1Al+S2AVg4g1HFTvibUhcXUG3RBX9BB NEwxz3Uk9MVnAqUwRqr3endr+szhIKw11iTS5eeMOjjE7EO8oYgOV9rtTuM/a03mpVmT hrMiLyX1mcvxsnvdIrrM8i0XaPE8OKJYzlwljqRIdY+nN+VGhpPhRcRYKimDWPs2W2Bv ebqgGvqZVcTTyhVPXsxwGsTp8ehZdNvz4ueo6VpbuMrkc/jdDPiTWuWx4Rp6kJfPQg+/ h4TQH77Q1bMNCM/AlrxeunkPVNkWSOcI/gwKJ6J7raZ2ubdIiW9VEool8EO/PpRiQqlZ azsA== X-Gm-Message-State: AGi0PuYoZhExps7qyWpPEVkUYc+tWKuCvytSePyvBliOD4QZhudgXouJ EvdFJKlGyHbdMQRIAbrYTzyqkLRfhwu+ew4Ogmo= X-Google-Smtp-Source: APiQypJTnW14byeH+e6ys9ObmJpNDwBZQMnIw0I/RpkkMr1a6uQRSalKPo/NqO1Te5BDCYL/ANjBpS8863SkAr7s4Tg= X-Received: by 2002:adf:e487:: with SMTP id i7mr19269763wrm.393.1589206257396; Mon, 11 May 2020 07:10:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carsten Dominik Date: Mon, 11 May 2020 16:10:40 +0200 Message-ID: Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo To: Kaushal Modi Content-Type: multipart/alternative; boundary="00000000000072709b05a55feadb" Received-SPF: pass client-ip=209.85.221.67; envelope-from=carsten.dominik@gmail.com; helo=mail-wr1-f67.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 10:10:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: 0.09 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=uva.nl (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [0.09 / 13.00]; GENERIC_REPUTATION(0.00)[-0.54013486730983]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.07), country: US(-0.00), ip: 209.51.188.17(-0.54)]; URI_COUNT_ODD(1.00)[9]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[dominik@uva.nl,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[travis-ci.org:url]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[emacs-orgmode@gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[uva.nl : SPF not aligned (relaxed), No valid DKIM,none] X-TUID: rKZf4VC7OrUl --00000000000072709b05a55feadb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi everyone, I just tried to archive something and hit again the issue that org-get-outline-paths undefined. Is there a specific holdup why this function has not been moved back into org.el? Thanks Carsten On Thu, Feb 27, 2020 at 3:02 PM Kaushal Modi wrote= : > Hello, > > I recently updated to the latest org-mode master and it is failing > ox-hugo[1] build and tests at 2 places. > > Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS > > Compiling ox-hugo.el now gives: > > ox-hugo.el:4284:1: Warning: the function =E2=80=98org-get-outline-path=E2= =80=99 is not > known to be defined. > > I see that defun has now moved to org-refile.el. I see that > org-get-outline-path has nothing to do specific to refiling. Can that be > moved back to org.el, or may be a separate library? Otherwise, ox-hugo.el > will have to load org-refile.el too (yes, I don't use org-refile (yet), a= nd > that's how I discovered this :)) > > Failure 2: Change in parsing of org babel header arguments. > > This was caught by my weekly Travis CI cron jobs for ox-hugo: > https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#L2426 > > 26c26 > < {{< highlight emacs-lisp "hl_lines=3D1" >}} > --- > > {{< highlight emacs-lisp "hl_lines=3D1 3-5" >}} > > Earlier this kind of src block header: > > #+begin_src emacs-lisp :hl_lines 1,3-5 > ... > #+end_src > > got exported as > > {{< highlight emacs-lisp "hl_lines=3D1 3-5" >}} > > The regression is that now it is getting exported as > > {{< highlight emacs-lisp "hl_lines=3D1" >}} > > The values that I have after the comma in ":hl_lines 1,3-5" are getting > lost. > > The relevant snippet where I parse the header arguments in ox-hugo.el is > at > https://github.com/kaushalmodi/ox-hugo/blob/f8ec4aa5ad7d92f94bd8dbb814d85= f980be67aea/ox-hugo.el#L2563 > > This behavior change in org-babel-parse-header-arguments is also not > documented in ORG-NEWS. I will now investigate what cause this regression= . > > ... > > -- > Kaushal Modi > > [1]: https://github.com/kaushalmodi/ox-hugo > --00000000000072709b05a55feadb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi everyone,

I just tried to archive so= mething=C2=A0and hit again the issue that org-get-outline-paths=C2=A0undefi= ned.=C2=A0 Is there a specific holdup why this function has not=C2=A0been m= oved back into org.el?

Thanks

=
Carsten


On Thu, Feb 27, 2020 at 3:02 PM Kaushal Mo= di <kaushal.modi@gmail.com= > wrote:
Hello,

I recently updated to the= latest org-mode master and it is failing ox-hugo[1] build and tests at 2 p= laces.

Failure 1: org-get-outline-path has mo= ved, and not mentioned in ORG-NEWS

Compiling ox-hu= go.el now gives:

ox-hugo.el:4284:1: Warning: the f= unction =E2=80=98org-get-outline-path=E2=80=99 is not known to be defined.<= br>

I see that defun has now moved to org-refile.e= l. I see that org-get-outline-path has nothing to do specific to refiling. = Can that be moved back to org.el, or may be a separate library? Otherwise, = ox-hugo.el will have to load org-refile.el too (yes, I don't use org-re= file (yet), and that's how I discovered this :))

Failure 2: Change in parsing of org babel header arguments.
This was caught by my weekly Travis CI cron jobs for ox-hugo: = https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#= L2426

26c26
< {{< highlight emacs-lisp "hl_lines= =3D1" >}}
---
> {{< highlight emacs-lisp "hl_lines= =3D1 3-5" >}}

Earlier this kind of src block header:

= #+begin_src emacs-lisp :hl_lines 1,3-5
...
#+end_src

got exported as=C2=A0

{{< highlight emacs-lisp "hl_lines=3D1 3-5" >}}
<= div>
The regression is that now it is getting exported as

{{< highlight emacs-lisp "hl_lines=3D1" >}}

The values that I have after the comma in ":= hl_lines 1,3-5" are getting lost.

The relevan= t snippet where I parse the header arguments in ox-hugo.el is at https://github.com/kaushalmo= di/ox-hugo/blob/f8ec4aa5ad7d92f94bd8dbb814d85f980be67aea/ox-hugo.el#L2563


--00000000000072709b05a55feadb--