emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: stardiviner <numbchild@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: commit "328c9a1af * bad org.el: Enhance menus" caused error
Date: Thu, 06 Feb 2020 15:11:30 +0800	[thread overview]
Message-ID: <877e10yyu5.fsf@gmail.com> (raw)
In-Reply-To: <87zhdxngv4.fsf@gnu.org>


Bastien <bzg@gnu.org> writes:

> Hi,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> BTW, the function ~org-insert-dblock-bindings~ is from package
>> =orgtbl-aggregate=.
>
> I don't know this function and this package.
>
> Can you share the minimal Emacs config with which you reproduce
> the problem?

Besides of package =orgtbl-aggregate=, seems another package =orgtbl-ascii-plot= use
same code to define menu too. Here is its code:

#+begin_src emacs-lisp
;;;###autoload
(defun orgtbl-ascii-plot-bindings ()
  (org-defkey org-mode-map "\C-c\"a"  'orgtbl-ascii-plot)
  (org-defkey org-mode-map "\C-c\"g"  'org-plot/gnuplot)
  (easy-menu-add-item
   org-tbl-menu '("Column")
   ["Ascii plot" orgtbl-ascii-plot t]))

;;;###autoload
(if (functionp 'org-defkey)
    (orgtbl-ascii-plot-bindings) ;; org-mode already loaded
  (setq org-load-hook            ;; org-mode will be loaded later
	      (cons 'orgtbl-ascii-plot-bindings
	            (if (boundp 'org-load-hook)
		              org-load-hook))))
#+end_src

Bastien, might consider add a hook after loaded org menus? Like named
~org-menu-after-loaded-hook~ or something else? So third libraries can define menu
entries with function added on the hook. I think those packages will have to
updated with patches?

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

      parent reply	other threads:[~2020-02-06  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 15:12 commit "328c9a1af * bad org.el: Enhance menus" caused error stardiviner
2020-02-05 15:18 ` stardiviner
2020-02-05 16:22   ` Bastien
2020-02-06  3:36     ` stardiviner
2020-02-07 19:47       ` Bastien
2020-02-11  5:06         ` [SOLVED] " stardiviner
2020-02-06  7:11     ` stardiviner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e10yyu5.fsf@gmail.com \
    --to=numbchild@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).