From mboxrd@z Thu Jan  1 00:00:00 1970
From: stardiviner <numbchild@gmail.com>
Subject: Re: commit "328c9a1af * bad org.el: Enhance menus" caused error
Date: Thu, 06 Feb 2020 15:11:30 +0800
Message-ID: <877e10yyu5.fsf@gmail.com>
References: <877e115aqd.fsf@gmail.com> <875zgl5ah3.fsf@gmail.com>
 <87zhdxngv4.fsf@gnu.org>
Reply-To: numbchild@gmail.com
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:54057)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <numbchild@gmail.com>) id 1izbKB-0006rn-Gj
 for emacs-orgmode@gnu.org; Thu, 06 Feb 2020 02:11:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <numbchild@gmail.com>) id 1izbKA-00043V-En
 for emacs-orgmode@gnu.org; Thu, 06 Feb 2020 02:11:43 -0500
In-reply-to: <87zhdxngv4.fsf@gnu.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Bastien <bzg@gnu.org>
Cc: Org Mode <emacs-orgmode@gnu.org>


Bastien <bzg@gnu.org> writes:

> Hi,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> BTW, the function ~org-insert-dblock-bindings~ is from package
>> =orgtbl-aggregate=.
>
> I don't know this function and this package.
>
> Can you share the minimal Emacs config with which you reproduce
> the problem?

Besides of package =orgtbl-aggregate=, seems another package =orgtbl-ascii-plot= use
same code to define menu too. Here is its code:

#+begin_src emacs-lisp
;;;###autoload
(defun orgtbl-ascii-plot-bindings ()
  (org-defkey org-mode-map "\C-c\"a"  'orgtbl-ascii-plot)
  (org-defkey org-mode-map "\C-c\"g"  'org-plot/gnuplot)
  (easy-menu-add-item
   org-tbl-menu '("Column")
   ["Ascii plot" orgtbl-ascii-plot t]))

;;;###autoload
(if (functionp 'org-defkey)
    (orgtbl-ascii-plot-bindings) ;; org-mode already loaded
  (setq org-load-hook            ;; org-mode will be loaded later
	      (cons 'orgtbl-ascii-plot-bindings
	            (if (boundp 'org-load-hook)
		              org-load-hook))))
#+end_src

Bastien, might consider add a hook after loaded org menus? Like named
~org-menu-after-loaded-hook~ or something else? So third libraries can define menu
entries with function added on the hook. I think those packages will have to
updated with patches?

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3