Re: [PATCH v2] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands

[Evgenii Klimov <eugene.dev@lipklim.org>]

Ihor Radchenko <yantar92@posteo.net> writes:

[...]
>> +individual commands for more information.
>> +
>> +This function runs the hook `org-shiftmetaleft-hook' as a first
>> +step, `org-shiftmetaleft-final-hook' as the penultimate step, and
>> +returns at first non-nil value."
>
> Upon looking closer, I realized that you also defined return value of
> the function here.  Is there any particular reason for this? The return
> value is currently not defined and supposed to be discarded.

Maybe I got it wrong, but I tried to follow the docstring for
`org-metaleft'. And I don't see here the use of the return value either:

#+begin_example
  (defun org-metaleft (&optional _arg)
    "...
    This function runs the hook `org-metaleft-hook' as a first step,
    and returns at first non-nil value."
    ...)
#+end_example

Should I keep it like this?
  This function runs the hook `org-shiftmetaleft-hook' as a first
  step, and `org-shiftmetaleft-final-hook' as the penultimate step.