From: Ihor Radchenko <yantar92@posteo.net>
To: Evgenii Klimov <eugene.dev@lipklim.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands
Date: Tue, 04 Jul 2023 11:34:35 +0000 [thread overview]
Message-ID: <874jmjvrjo.fsf@localhost> (raw)
In-Reply-To: <877crgwy82.fsf@lipklim.org>
Evgenii Klimov <eugene.dev@lipklim.org> writes:
> Maybe I got it wrong, but I tried to follow the docstring for
> `org-metaleft'. And I don't see here the use of the return value either:
>
> #+begin_example
> (defun org-metaleft (&optional _arg)
> "...
> This function runs the hook `org-metaleft-hook' as a first step,
> and returns at first non-nil value."
> ...)
> #+end_example
> Should I keep it like this?
> This function runs the hook `org-shiftmetaleft-hook' as a first
> step, and `org-shiftmetaleft-final-hook' as the penultimate step.
Apparently the original wording is quite confusing.
What it is supposed to say is:
This function runs the functions in `org-metaleft-hook' one by one
as a first step, and exits immediately if a function from the hook
returns non-nil.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-04 11:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 22:31 Add final hooks to S-/M-/S-M-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 1/3] lisp/org.el: Add final hooks to the M-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 2/3] lisp/org.el: Fix docstring for S-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 3/3] lisp/org.el: Add final hooks to the S-M-cursor commands Evgenii Klimov
2023-07-01 10:40 ` Add final hooks to S-/M-/S-M-cursor commands Ihor Radchenko
2023-07-01 12:16 ` Evgenii Klimov
2023-07-01 12:22 ` Ihor Radchenko
2023-07-01 13:19 ` [PATCH v2] lisp/org.el: " Evgenii Klimov
2023-07-03 12:44 ` Ihor Radchenko
2023-07-03 19:40 ` Evgenii Klimov
2023-07-04 11:34 ` Ihor Radchenko [this message]
2023-07-04 22:28 ` [PATCH v3] " Evgenii Klimov
2023-07-05 10:46 ` Ihor Radchenko
2023-07-05 11:14 ` Evgenii Klimov
2023-07-05 11:27 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jmjvrjo.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=eugene.dev@lipklim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).