From: Evgenii Klimov <eugene.dev@lipklim.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands
Date: Mon, 03 Jul 2023 20:40:50 +0100 [thread overview]
Message-ID: <877crgwy82.fsf@lipklim.org> (raw)
In-Reply-To: <87ilb1go5p.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
[...]
>> +individual commands for more information.
>> +
>> +This function runs the hook `org-shiftmetaleft-hook' as a first
>> +step, `org-shiftmetaleft-final-hook' as the penultimate step, and
>> +returns at first non-nil value."
>
> Upon looking closer, I realized that you also defined return value of
> the function here. Is there any particular reason for this? The return
> value is currently not defined and supposed to be discarded.
Maybe I got it wrong, but I tried to follow the docstring for
`org-metaleft'. And I don't see here the use of the return value either:
#+begin_example
(defun org-metaleft (&optional _arg)
"...
This function runs the hook `org-metaleft-hook' as a first step,
and returns at first non-nil value."
...)
#+end_example
Should I keep it like this?
This function runs the hook `org-shiftmetaleft-hook' as a first
step, and `org-shiftmetaleft-final-hook' as the penultimate step.
next prev parent reply other threads:[~2023-07-03 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 22:31 Add final hooks to S-/M-/S-M-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 1/3] lisp/org.el: Add final hooks to the M-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 2/3] lisp/org.el: Fix docstring for S-cursor commands Evgenii Klimov
2023-06-29 22:31 ` [PATCH 3/3] lisp/org.el: Add final hooks to the S-M-cursor commands Evgenii Klimov
2023-07-01 10:40 ` Add final hooks to S-/M-/S-M-cursor commands Ihor Radchenko
2023-07-01 12:16 ` Evgenii Klimov
2023-07-01 12:22 ` Ihor Radchenko
2023-07-01 13:19 ` [PATCH v2] lisp/org.el: " Evgenii Klimov
2023-07-03 12:44 ` Ihor Radchenko
2023-07-03 19:40 ` Evgenii Klimov [this message]
2023-07-04 11:34 ` Ihor Radchenko
2023-07-04 22:28 ` [PATCH v3] " Evgenii Klimov
2023-07-05 10:46 ` Ihor Radchenko
2023-07-05 11:14 ` Evgenii Klimov
2023-07-05 11:27 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877crgwy82.fsf@lipklim.org \
--to=eugene.dev@lipklim.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).