Commit "org-agenda: Support for dimming..." breaks agenda display

Commit "org-agenda: Support for dimming..." breaks agenda display

[Oleh Krehel]

Hi all,

I updated Org recently and noticed that the agenda display looks very
broken, especially in `org-agenda-log-mode'.

I did a bisect; reverting commit
912a385518bcf2e320cc161d573ad329111de6c7 fixes it.
Anyone else have this problem?

regards,
Oleh

Re: Commit "org-agenda: Support for dimming..." breaks agenda display

[Nicolas Goaziou]

Hello,

Oleh Krehel <ohwoeowho@gmail.com> writes:

> I updated Org recently and noticed that the agenda display looks very
> broken, especially in `org-agenda-log-mode'.
>
> I did a bisect; reverting commit
> 912a385518bcf2e320cc161d573ad329111de6c7 fixes it.
> Anyone else have this problem?

Confirmed. See also
<http://lists.gnu.org/archive/html/emacs-orgmode/2017-08/msg00134.html>.

I'm Cc'ing Yuri about it.

Regards,

-- 
Nicolas Goaziou

Re: Commit "org-agenda: Support for dimming..." breaks agenda display

[Yuri Lensky]

[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]

Hi,

I have a attached a patch to fix this bug. As can be seen from the patch,
the problem was improperly balanced parenthesis in
`org-agenda--mark-blocked-entry' which caused the function to return 'nil
unless the entry passed to it had the todo-state text property, whereas the
proper behavior is to always return the entry in some form.

Apologies for carelessness and introducing the bug,

YL

On Sun, Aug 6, 2017 at 3:55 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
> > I updated Org recently and noticed that the agenda display looks very
> > broken, especially in `org-agenda-log-mode'.
> >
> > I did a bisect; reverting commit
> > 912a385518bcf2e320cc161d573ad329111de6c7 fixes it.
> > Anyone else have this problem?
>
> Confirmed. See also
> <http://lists.gnu.org/archive/html/emacs-orgmode/2017-08/msg00134.html>.
>
> I'm Cc'ing Yuri about it.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #1.2: Type: text/html, Size: 1655 bytes --]

[-- Attachment #2: 0001-lisp-org-agenda.el-Properly-return-all-entries-from-.patch --]
[-- Type: application/octet-stream, Size: 995 bytes --]

From b942de6e68836953b7c168fa1b783a87b8c6bf42 Mon Sep 17 00:00:00 2001
From: "Yuri D. Lensky" <ydlensky@gmail.com>
Date: Mon, 7 Aug 2017 02:12:26 -0400
Subject: [PATCH] lisp/org-agenda.el: Properly return all entries from blocked
 marking

* lisp/org-agenda.el (org-agenda--mark-blocked-entry): Always return
  the entry passed to `org-agenda--mark-blocked-entry' (previously
  returned nil if entry did not have todo-state text property).
---
 lisp/org-agenda.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 1355023..c8097de 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3930,8 +3930,8 @@ to t."
 	      (put-text-property
 	       0 (length entry) 'org-todo-blocked
 	       (if really-invisible 'invisible t)
-	       entry))))))
-    entry))
+	       entry)))))))
+  entry)
 
 (defvar org-agenda-skip-function nil
   "Function to be called at each match during agenda construction.
-- 
2.9.2.windows.1

Re: Commit "org-agenda: Support for dimming..." breaks agenda display

[Nicolas Goaziou]

Hello,

Yuri Lensky <ydlensky@gmail.com> writes:

> I have a attached a patch to fix this bug. As can be seen from the patch,
> the problem was improperly balanced parenthesis in
> `org-agenda--mark-blocked-entry' which caused the function to return 'nil
> unless the entry passed to it had the todo-state text property, whereas the
> proper behavior is to always return the entry in some form.
>
> Apologies for carelessness and introducing the bug,

No worries. Thank you for the quick fix!

Applied.


Regards,

-- 
Nicolas Goaziou                                                0x80A93738