From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuri Lensky Subject: Re: Commit "org-agenda: Support for dimming..." breaks agenda display Date: Mon, 7 Aug 2017 02:31:07 -0400 Message-ID: References: <8760e1f7u9.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a113ce406fb6d41055623fd0c" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1debZI-0000id-SN for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 02:31:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1debZH-0001Mm-GL for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 02:31:12 -0400 Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:34647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1debZH-0001Lz-9p for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 02:31:11 -0400 Received: by mail-oi0-x22a.google.com with SMTP id x3so57770785oia.1 for ; Sun, 06 Aug 2017 23:31:09 -0700 (PDT) In-Reply-To: <8760e1f7u9.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: org mode , Oleh Krehel --001a113ce406fb6d41055623fd0c Content-Type: multipart/alternative; boundary="001a113ce406fb6d3d055623fd0a" --001a113ce406fb6d3d055623fd0a Content-Type: text/plain; charset="UTF-8" Hi, I have a attached a patch to fix this bug. As can be seen from the patch, the problem was improperly balanced parenthesis in `org-agenda--mark-blocked-entry' which caused the function to return 'nil unless the entry passed to it had the todo-state text property, whereas the proper behavior is to always return the entry in some form. Apologies for carelessness and introducing the bug, YL On Sun, Aug 6, 2017 at 3:55 AM, Nicolas Goaziou wrote: > Hello, > > Oleh Krehel writes: > > > I updated Org recently and noticed that the agenda display looks very > > broken, especially in `org-agenda-log-mode'. > > > > I did a bisect; reverting commit > > 912a385518bcf2e320cc161d573ad329111de6c7 fixes it. > > Anyone else have this problem? > > Confirmed. See also > . > > I'm Cc'ing Yuri about it. > > Regards, > > -- > Nicolas Goaziou > --001a113ce406fb6d3d055623fd0a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I have a attached a patch = to fix this bug. As can be seen from the patch, the problem was improperly = balanced parenthesis in `org-agenda--mark-blocked-entry' which caused t= he function to return 'nil unless the entry passed to it had the todo-s= tate text property, whereas the proper behavior is to always return the ent= ry in some form.

Apologies for carelessness and introducing th= e bug,

YL

On Sun, Aug 6, 2017 at 3:55 AM, Nicolas Goaziou <ma= il@nicolasgoaziou.fr> wrote:
ohwoeowho@gmail.com<= /a>> writes:

> I updated Org recently and noticed that the agenda display looks very<= br> > broken, especially in `org-agenda-log-mode'.
>
> I did a bisect; reverting commit
> 912a385518bcf2e320cc161d573ad329111de6c7 fixes it.
> Anyone else have this problem?

Confirmed. See also
<http://lists.gnu.org/archiv= e/html/emacs-orgmode/2017-08/msg00134.html>.

I'm Cc'ing Yuri about it.

Regards,

--
Nicolas Goaziou

--001a113ce406fb6d3d055623fd0a-- --001a113ce406fb6d41055623fd0c Content-Type: application/octet-stream; name="0001-lisp-org-agenda.el-Properly-return-all-entries-from-.patch" Content-Disposition: attachment; filename="0001-lisp-org-agenda.el-Properly-return-all-entries-from-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j61rsf7m0 RnJvbSBiOTQyZGU2ZTY4ODM2OTUzYjdjMTY4ZmExYjc4M2E4N2I4YzZiZjQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiWXVyaSBELiBMZW5za3kiIDx5ZGxlbnNreUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgNyBBdWcgMjAxNyAwMjoxMjoyNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGxp c3Avb3JnLWFnZW5kYS5lbDogUHJvcGVybHkgcmV0dXJuIGFsbCBlbnRyaWVzIGZyb20gYmxvY2tl ZAogbWFya2luZwoKKiBsaXNwL29yZy1hZ2VuZGEuZWwgKG9yZy1hZ2VuZGEtLW1hcmstYmxvY2tl ZC1lbnRyeSk6IEFsd2F5cyByZXR1cm4KICB0aGUgZW50cnkgcGFzc2VkIHRvIGBvcmctYWdlbmRh LS1tYXJrLWJsb2NrZWQtZW50cnknIChwcmV2aW91c2x5CiAgcmV0dXJuZWQgbmlsIGlmIGVudHJ5 IGRpZCBub3QgaGF2ZSB0b2RvLXN0YXRlIHRleHQgcHJvcGVydHkpLgotLS0KIGxpc3Avb3JnLWFn ZW5kYS5lbCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy1hZ2VuZGEuZWwgYi9saXNwL29yZy1hZ2Vu ZGEuZWwKaW5kZXggMTM1NTAyMy4uYzgwOTdkZSAxMDA2NDQKLS0tIGEvbGlzcC9vcmctYWdlbmRh LmVsCisrKyBiL2xpc3Avb3JnLWFnZW5kYS5lbApAQCAtMzkzMCw4ICszOTMwLDggQEAgdG8gdC4i CiAJICAgICAgKHB1dC10ZXh0LXByb3BlcnR5CiAJICAgICAgIDAgKGxlbmd0aCBlbnRyeSkgJ29y Zy10b2RvLWJsb2NrZWQKIAkgICAgICAgKGlmIHJlYWxseS1pbnZpc2libGUgJ2ludmlzaWJsZSB0 KQotCSAgICAgICBlbnRyeSkpKSkpKQotICAgIGVudHJ5KSkKKwkgICAgICAgZW50cnkpKSkpKSkp CisgIGVudHJ5KQogCiAoZGVmdmFyIG9yZy1hZ2VuZGEtc2tpcC1mdW5jdGlvbiBuaWwKICAgIkZ1 bmN0aW9uIHRvIGJlIGNhbGxlZCBhdCBlYWNoIG1hdGNoIGR1cmluZyBhZ2VuZGEgY29uc3RydWN0 aW9uLgotLSAKMi45LjIud2luZG93cy4xCgo= --001a113ce406fb6d41055623fd0c--