emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "N. Jackson" <nljlistbox2@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda: Use `window-max-chars-per-line' instead of `window-width'
Date: Thu, 21 Apr 2022 03:56:32 -0400	[thread overview]
Message-ID: <875yn2vphr.fsf@moondust.localdomain> (raw)
In-Reply-To: <87a6cekitg.fsf@moondust.localdomain> (N. Jackson's message of "Thu, 21 Apr 2022 03:16:11 -0400")


Hello Ihor,

At 03:16 -0400 on Thursday 2022-04-21, N. Jackson wrote:
>
> However, the problem with the tags wrapping in Agenda (instead of
> being right aligned) remains.

I believe the problem with the wrapping of the Agenda tags is here:

  (defun org-agenda-align-tags (&optional line)
    "Align all tags in agenda items to `org-agenda-tags-column'.
  When optional argument LINE is non-nil, align tags only on the
  current line."
    (let ((inhibit-read-only t)
          (org-agenda-tags-column (if (eq 'auto org-agenda-tags-column)
                                      (- (window-text-width))
                                          ^^^^^^^^^^^^^^^^^
                                    org-agenda-tags-column))
          (end (and line (line-end-position)))
          l c)
  ...

Changing window-text-width to window-max-chars-per-line fixes the
problem here and seems like the right thing to do.

Regards,
N.



  reply	other threads:[~2022-04-21  8:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 13:10 [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] N. Jackson
2022-04-18 13:39 ` Ihor Radchenko
2022-04-18 19:06   ` N. Jackson
2022-04-19  3:16     ` Ihor Radchenko
2022-04-19 14:06       ` [BUG] Off-by-one error in width of Agenda window? N. Jackson
2022-04-20  4:01         ` Ihor Radchenko
2022-04-20 10:07           ` N. Jackson
2022-04-21  5:25             ` [PATCH] org-agenda: Use `window-max-chars-per-line' instead of `window-width' Ihor Radchenko
2022-04-21  7:16               ` N. Jackson
2022-04-21  7:56                 ` N. Jackson [this message]
2022-04-22  5:58                   ` [PATCH v2] org-agenda: Use `window-max-chars-per-line' to calculate max text width Ihor Radchenko
2022-04-22  8:42                     ` N. Jackson
2022-04-22  9:27                       ` Ihor Radchenko
2022-04-22 15:46                         ` N. Jackson
2022-04-24  7:04                           ` Ihor Radchenko
2022-04-24 11:55                             ` Thank you " N. Jackson
2022-04-18 14:30 ` [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] Tory S. Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yn2vphr.fsf@moondust.localdomain \
    --to=nljlistbox2@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).