From: "N. Jackson" <nljlistbox2@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] org-agenda: Use `window-max-chars-per-line' to calculate max text width
Date: Fri, 22 Apr 2022 11:46:24 -0400 [thread overview]
Message-ID: <8735i5w27j.fsf@moondust.localdomain> (raw)
In-Reply-To: <87y1zxsc1z.fsf@localhost> (Ihor Radchenko's message of "Fri, 22 Apr 2022 17:27:20 +0800")
At 17:27 +0800 on Friday 2022-04-22, Ihor Radchenko wrote:
>
> "N. Jackson" <nljlistbox2@gmail.com> writes:
>>
>> If Org needs to support versions of Emacs before 25.1 then I assume
>> you need the same guard on every instance of
>> window-max-chars-per-line -- because window-max-chars-per-line was
>> added to Emacs at the same time as window-font-width:
>
> We do not need to worry about this. Org supports the latest released
> Emacs version + 2 previous [1]. Now, it means Emacs >=26.
>
> [1] https://orgmode.org/worg/org-maintenance.html#emacs-compatibility
Ah, I didn't know that. Thanks.
I have tested with your v2 patch applied to Org 9.5.3:
1. It fixes the two bugs I reported in this thread (with one or both fringes
off, Agenda wraps `auto' (right) aligned tags unnecessarily and wraps the block
separator).
2. It also makes the Agenda display properly after the font size has been
altered with C-x +/-. This didn't work before, even with default fringes. [One
has to hit `g' to refresh the Agenda after changing the font size.]
3. As is to be expected, it doesn't help with an Agenda displayed with a
proportional font -- but it doesn't seem to make things any worse.
FWIW a summary of my testing of tags alignment, separator width, and new time
stamps for various fringe modes is shown below.
1. With my normal default font (-PfEd-DejaVu Sans
Mono-normal-normal-normal-*-11-*-*-*-m-0-iso10646-1):
|----------------+-------+-----------+-------+-----------+-------+-----------|
| | Tags alignment | Separator width | New time |
| Fringe mode +-------+-----------+-------+-----------+-------+-----------|
| | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch |
|----------------+-------+-----------+-------+-----------+-------+-----------|
| Default (Both) | OK | OK | OK | OK | OK | OK |
| Minimal | OK | OK | OK | OK | OK | OK |
| Left only | FAIL | OK | FAIL | OK | OK | OK |
| Right only | FAIL | OK | FAIL | OK | OK | OK |
| No fringes | FAIL | OK | FAIL | OK | OK | OK |
|----------------+-------+-----------+-------+-----------+-------+-----------|
2. After `C-x + + +' and also `C-x - - -' (giving -PfEd-DejaVu Sans
Mono-normal-normal-normal-*-21-*-*-*-m-0-iso10646-1 and -PfEd-DejaVu Sans
Mono-normal-normal-normal-*-7-*-*-*-m-0-iso10646-1):
|----------------+-------+-----------+-------+-----------+-------+-----------|
| | Tags alignment | Separator width | New time |
| Fringe mode +-------+-----------+-------+-----------+-------+-----------|
| | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch |
|----------------+-------+-----------+-------+-----------+-------+-----------|
| Default (Both) | FAIL | OK | FAIL | OK | OK | OK |
| Minimal | FAIL | OK | FAIL | OK | OK | OK |
| Left only | FAIL | OK | FAIL | OK | OK | OK |
| Right only | FAIL | OK | FAIL | OK | OK | OK |
| No fringes | FAIL | OK | FAIL | OK | OK | OK |
|----------------+-------+-----------+-------+-----------+-------+-----------|
3. With a proportional font (-1ASC-Liberation
Sans-normal-normal-normal-*-13-*-*-*-*-0-iso10646-1):
|----------------+-------+-----------+-------+-----------+-------+-----------|
| | Tags alignment | Separator width | New time |
| Fringe mode +-------+-----------+-------+-----------+-------+-----------|
| | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch |
|----------------+-------+-----------+-------+-----------+-------+-----------|
| Default (both) | FAIL | FAIL | FAIL | FAIL | OK | OK |
| Minimal | FAIL | FAIL | FAIL | FAIL | OK | OK |
| Left only | FAIL | FAIL | FAIL | FAIL | OK | OK |
| Right only | FAIL | FAIL | FAIL | FAIL | OK | OK |
| No fringes | FAIL | FAIL | FAIL | FAIL | OK | OK |
|----------------+-------+-----------+-------+-----------+-------+-----------|
Note: My testing of the position of the new time stamps was only cursory. I
never pay attention to them in normal use. I just checked that they were
approximately right aligned. [I think, in fact, that both before and after your
patch the behaviour isn't quite correct -- the stamps appear to be one character
too far to the left. Of course that is barely noticeable and there are clearly
far far more important things in Org to be worked on.]
Regards,
N.
next prev parent reply other threads:[~2022-04-22 15:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 13:10 [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] N. Jackson
2022-04-18 13:39 ` Ihor Radchenko
2022-04-18 19:06 ` N. Jackson
2022-04-19 3:16 ` Ihor Radchenko
2022-04-19 14:06 ` [BUG] Off-by-one error in width of Agenda window? N. Jackson
2022-04-20 4:01 ` Ihor Radchenko
2022-04-20 10:07 ` N. Jackson
2022-04-21 5:25 ` [PATCH] org-agenda: Use `window-max-chars-per-line' instead of `window-width' Ihor Radchenko
2022-04-21 7:16 ` N. Jackson
2022-04-21 7:56 ` N. Jackson
2022-04-22 5:58 ` [PATCH v2] org-agenda: Use `window-max-chars-per-line' to calculate max text width Ihor Radchenko
2022-04-22 8:42 ` N. Jackson
2022-04-22 9:27 ` Ihor Radchenko
2022-04-22 15:46 ` N. Jackson [this message]
2022-04-24 7:04 ` Ihor Radchenko
2022-04-24 11:55 ` Thank you " N. Jackson
2022-04-18 14:30 ` [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] Tory S. Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735i5w27j.fsf@moondust.localdomain \
--to=nljlistbox2@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).