From: Ihor Radchenko <yantar92@posteo.net>
To: Damien Cassou <damien@cassou.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: Request for feedback: ox-linuxmag
Date: Mon, 24 Oct 2022 13:55:24 +0000 [thread overview]
Message-ID: <875yg9uy0j.fsf@localhost> (raw)
In-Reply-To: <87h6zunxvy.fsf@cassou.me>
Damien Cassou <damien@cassou.me> writes:
> I'm done writing ox-linuxmag, an exporter for the French GNU/Linux
> Magazine: https://github.com/DamienCassou/ox-linuxmag.
Why not using org-export-define-derived-backend?
Also, linuxmag might be confused with
https://www.linux-magazine.com/tags/view/Operating+Systems/GNU
> (defconst ox-linuxmag--resources-dir
> (expand-file-name "resources" (file-name-directory (or load-file-name (buffer-file-name))))
> "Directory containing the style and template XML files.")
This will spoil the installation dir.
> ox-linuxmag--template
Your template function has side effects. Side effects are usually
implemented inside the export function. like ox-linuxmag--export-to-odt
> ox-linuxmag--export-to-odt
Why is it marked as private function? By convention, Org exporters
provide public function to export programatically.
And it is (interactive), which is even more strange given that it is
marked private (--).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-24 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 19:27 Request for feedback: ox-linuxmag Damien Cassou
2022-10-24 13:55 ` Ihor Radchenko [this message]
2022-10-24 19:45 ` Damien Cassou
2022-10-25 8:02 ` Ihor Radchenko
2022-10-26 19:58 ` Damien Cassou
2022-10-28 2:26 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yg9uy0j.fsf@localhost \
--to=yantar92@posteo.net \
--cc=damien@cassou.me \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).