From: Damien Cassou <damien@cassou.me>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Request for feedback: ox-linuxmag
Date: Mon, 24 Oct 2022 21:45:16 +0200 [thread overview]
Message-ID: <87k04pgg4z.fsf@cassou.me> (raw)
In-Reply-To: <875yg9uy0j.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Why not using org-export-define-derived-backend?
I didn't know this function exist. I changed the code to use it.
> Also, linuxmag might be confused with…
What do you think about ox-linuxmag-fr as package name and linuxmag-fr
as exporter name?
>> (defconst ox-linuxmag--resources-dir
>> (expand-file-name "resources" (file-name-directory (or load-file-name (buffer-file-name))))
>> "Directory containing the style and template XML files.")
>
> This will spoil the installation dir.
What do you mean by that? Do you have a different way to do it? The odt
exporter contains a similar variable and external files (see
`org-odt-lib-dir`).
> Your template function has side effects. Side effects are usually
> implemented inside the export function. like ox-linuxmag--export-to-odt
I guess you are referring to `ox-linuxmag--write-meta-file` and
`ox-linuxmag--write-styles-file`. I would be happy to move them to the
export function but they depend on `info` and I don't know how to get
that from there. Also, I copy/pasted the structure of ox-odt which does
something similar in `org-odt-template`.
Any recommendation?
>> ox-linuxmag--export-to-odt
>
> Why is it marked as private function? By convention, Org exporters
> provide public function to export programatically.
You are perfectly right. This is now fixed.
Thank you very much for helping me improve the code! I really appreciate
the time and effort.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
next prev parent reply other threads:[~2022-10-24 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 19:27 Request for feedback: ox-linuxmag Damien Cassou
2022-10-24 13:55 ` Ihor Radchenko
2022-10-24 19:45 ` Damien Cassou [this message]
2022-10-25 8:02 ` Ihor Radchenko
2022-10-26 19:58 ` Damien Cassou
2022-10-28 2:26 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k04pgg4z.fsf@cassou.me \
--to=damien@cassou.me \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).