emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: The "problem" with `flet' in Org-mode and (future) Emacs 24.2
Date: Mon, 23 Jul 2012 19:41:31 +0200	[thread overview]
Message-ID: <874noyjrxw.fsf@Rainer.invalid> (raw)
In-Reply-To: 87obnacoq6.fsf@gmx.com

Eric Schulte writes:
> Okay, I've noticed a number of these errors as well.  It looks like the
> old version of flet allowed the definition of recursive functions, but
> the new cl-flet does not.

The defalias checks for the wrong Emacs version.  I've just built
another Emacs24 which got version 24.1.2, of which the "2" really is the
build number; this should fix it (trunk starts from 24.1.50.1):


diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index 41ae999..ad04ccd 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -115,19 +115,11 @@ (defun org-emacs-full-version ()
 
 \f
 ;;; cl macros no longer available in the trunk
-(defalias 'org-flet (if (or (> emacs-major-version 24)
-			    (and (= emacs-major-version 24)
-				 (let ((full (org-emacs-full-version)))
-				   (and (third full)
-					(> (third full) 1)))))
+(defalias 'org-flet (if (org-version-check "24.1.50" "cl" :predicate)
 			'cl-flet*
 		      'flet))
 
-(defalias 'org-labels (if (or (> emacs-major-version 24)
-			      (and (= emacs-major-version 24)
-				   (let ((full (org-emacs-full-version)))
-				     (and (third full)
-					  (> (third full) 1)))))
+(defalias 'org-labels (if (org-version-check "24.1.50" "cl" :predicate)
 			  'cl-labels
 			'labels))



Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

  parent reply	other threads:[~2012-07-23 17:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  7:03 The "problem" with `flet' in Org-mode and (future) Emacs 24.2 Vladimir Lomov
2012-07-18 16:35 ` Eric Schulte
2012-07-18 18:33   ` Achim Gratz
2012-07-19  4:13     ` Eric Schulte
2012-07-19  6:27       ` Achim Gratz
2012-07-19 12:33       ` Vladimir Lomov
2012-07-20  1:19         ` Vladimir Lomov
2012-07-20  3:00           ` Vladimir Lomov
2012-07-20 17:43             ` Eric Schulte
2012-07-22  0:13               ` Vladimir Lomov
2012-07-22 19:30                 ` Achim Gratz
2012-07-25 15:26                   ` Eric Schulte
2012-07-25 16:45                     ` Achim Gratz
2012-07-25 16:54                       ` Eric Schulte
2012-07-26 12:28                     ` Bastien
2012-07-26 13:19                       ` Bastien
2012-07-26 14:36                         ` Bastien
2012-07-23 17:41               ` Achim Gratz [this message]
2012-07-19 14:12       ` Jambunathan K
2012-07-18 18:18 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874noyjrxw.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).