emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Vladimir Lomov <lomov.vl@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: The "problem" with `flet' in Org-mode and (future) Emacs 24.2
Date: Thu, 19 Jul 2012 21:33:57 +0900	[thread overview]
Message-ID: <20120719123357.GC890@smoon> (raw)
In-Reply-To: <87ipdko0al.fsf@gmx.com>

Hello,
** Eric Schulte [2012-07-18 22:13:45 -0600]:

> Achim Gratz <Stromeko@nexgo.de> writes:

>> Eric Schulte writes:
>>> This attached alternate patch introduces two new compatibility macros
>>> named `org-flet' and `org-labels' in org-macs.el.  These macros are
>>> aliased to the appropriate cl macro depending on the version of Emacs in
>>> use.

>> Wouldn't you want to use defmacro instead of defalias?

> Why?  Using `defalias' seems simpler because with `defmacro' I would
> have to copy the macro arguments and stub out a trivial macro body.
> Also, this way the version check only happens once (at load time),
> rather than every time the macro is called.

>> Also, I'd think that these two macros should go into org-compat.el
>> instead of org-macs.el.

> Agreed, I forgot about org-compat.  The alternate patch below moves
> these definitions from org-macs.el to org-compat.el.

> Thanks,

[...]

This is interesting, but seems not fully functional. After applying
patch I tried export to html but got

Symbol's function definition is void: matches

I'll compare your and mine patches later.

---
WBR, Vladimir Lomov

-- 
Never underestimate the bandwidth of a station wagon full of tapes.
		-- Dr. Warren Jackson, Director, UTCS

  parent reply	other threads:[~2012-07-19 12:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  7:03 The "problem" with `flet' in Org-mode and (future) Emacs 24.2 Vladimir Lomov
2012-07-18 16:35 ` Eric Schulte
2012-07-18 18:33   ` Achim Gratz
2012-07-19  4:13     ` Eric Schulte
2012-07-19  6:27       ` Achim Gratz
2012-07-19 12:33       ` Vladimir Lomov [this message]
2012-07-20  1:19         ` Vladimir Lomov
2012-07-20  3:00           ` Vladimir Lomov
2012-07-20 17:43             ` Eric Schulte
2012-07-22  0:13               ` Vladimir Lomov
2012-07-22 19:30                 ` Achim Gratz
2012-07-25 15:26                   ` Eric Schulte
2012-07-25 16:45                     ` Achim Gratz
2012-07-25 16:54                       ` Eric Schulte
2012-07-26 12:28                     ` Bastien
2012-07-26 13:19                       ` Bastien
2012-07-26 14:36                         ` Bastien
2012-07-23 17:41               ` Achim Gratz
2012-07-19 14:12       ` Jambunathan K
2012-07-18 18:18 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120719123357.GC890@smoon \
    --to=lomov.vl@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).