problem with org-caldav and ox-icalendar: UID property wrapping

problem with org-caldav and ox-icalendar: UID property wrapping

[Eric S Fraga]

Hello,

I have been using org-caldav for quite a while now and everything has
been fine with it until a few weeks ago.  All of a sudden, org-caldav
fails to sync with the following error:

,----
| (error "Could not find UID 0400[...]00.")
|   signal(error ("Could not find UID 0400[...]00."))
`----
  
(I have truncated the IDs for clarity and obfuscation using [...].)

The strange thing is that there is no such UID anywhere in my org
files.  However, there is one ID that has this UID as the prefix.  That
is, the ID matches this one but then has more characters.

I have tracked this down to org-icalendar outputing wrapped lines even
for UID entries:

,----
| BEGIN:VEVENT
| DTSTAMP:20140507T114443Z
| UID:0400[...]00
|  00[...]6
| DTSTART;TZID=Europe/London:20120403T060000
`----


Have the recent (in April) changes to ox-icalendar.el affected how IDs
are written out?  If so, could this be reverted?  Mind you, the output
is currently probably more conformant...

Ideally, org-caldav should be fixed to unwrap ID lines.  I can try to do
this but I need some help with regexps, specifically to match across two
lines: "\n ".

thanks,
eric

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.2, Org release_8.2.6-937-g60502a

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[Nicolas Goaziou]

Hello,

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> I have tracked this down to org-icalendar outputing wrapped lines even
> for UID entries:
>
> ,----
> | BEGIN:VEVENT
> | DTSTAMP:20140507T114443Z
> | UID:0400[...]00
> |  00[...]6
> | DTSTART;TZID=Europe/London:20120403T060000
> `----

AFAIU RFC 5545, all lines longer than 75 octets, including UID lines,
are expected to be folded. Therefore I think ox-icalendar is right.

> Have the recent (in April) changes to ox-icalendar.el affected how IDs
> are written out?

I don't think so.

> Ideally, org-caldav should be fixed to unwrap ID lines.

Indeed.

> I can try to do this but I need some help with regexps, specifically
> to match across two lines: "\n ".

You don't have to. For unfolding you only need to turn "\n " into "".


Regards,

-- 
Nicolas Goaziou

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[David Engster]

Nicolas Goaziou writes:
> Hello,
>
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>
>> I have tracked this down to org-icalendar outputing wrapped lines even
>> for UID entries:
>>
>> ,----
>> | BEGIN:VEVENT
>> | DTSTAMP:20140507T114443Z
>> | UID:0400[...]00
>> |  00[...]6
>> | DTSTART;TZID=Europe/London:20120403T060000
>> `----
>
> AFAIU RFC 5545, all lines longer than 75 octets, including UID lines,
> are expected to be folded. Therefore I think ox-icalendar is right.

Yes, it is.

I've already rewritten that part in org-caldav, but it needs more
testing. I'll push a fix in the coming days.

-David

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[Eric S Fraga]

On Wednesday,  7 May 2014 at 22:45, David Engster wrote:

[...]

> I've already rewritten that part in org-caldav, but it needs more
> testing. I'll push a fix in the coming days.

Excellent!  I look forward to the fix.  Thanks.

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.2, Org release_8.2.6-937-g60502a

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[David Engster]

David Engster writes:
> Nicolas Goaziou writes:
>> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>>> I have tracked this down to org-icalendar outputing wrapped lines even
>>> for UID entries:
>>>
>>> ,----
>>> | BEGIN:VEVENT
>>> | DTSTAMP:20140507T114443Z
>>> | UID:0400[...]00
>>> |  00[...]6
>>> | DTSTART;TZID=Europe/London:20120403T060000
>>> `----
>>
>> AFAIU RFC 5545, all lines longer than 75 octets, including UID lines,
>> are expected to be folded. Therefore I think ox-icalendar is right.
>
> Yes, it is.
>
> I've already rewritten that part in org-caldav, but it needs more
> testing. I'll push a fix in the coming days.

Well, that took a bit longer, but I pushed it now...

-David

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[Eric S Fraga]

On Tuesday,  3 Jun 2014 at 21:54, David Engster wrote:

[...]

> Well, that took a bit longer, but I pushed it now...
>
> -David

Well, the good news is that you have indeed fixed the problem I noted
about IDs on more than one line.

The bad news is that other things are now broken.  I haven't had time to
totally narrow down was is happening but basically:

If I run org-caldav-sync several times after having inserted a new item
on the org side, the following happens:

Sync 1: new item in org gets copied to Google fine.
Sync 2: the item is copied back from Google in to org
Sync 3: the original org item is deleted and another copy of Google's
        version is transferred. 

I'll play some more later when I have time.  Off to examine students now
:)

Thanks,
eric
-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.2, Org release_8.2.6-949-g751506

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[David Engster]

Eric S. Fraga writes:
> On Tuesday,  3 Jun 2014 at 21:54, David Engster wrote:
>
> [...]
>
>> Well, that took a bit longer, but I pushed it now...
>>
>> -David
>
> Well, the good news is that you have indeed fixed the problem I noted
> about IDs on more than one line.
>
> The bad news is that other things are now broken.  I haven't had time to
> totally narrow down was is happening but basically:

Yes, I made a stupid mistake. I hope it is fixed now, but it might be
necessary to delete the remote calendars and sync anew. Sorry for that.

-David

Re: problem with org-caldav and ox-icalendar: UID property wrapping

[Eric S Fraga]

On Thursday,  5 Jun 2014 at 22:28, David Engster wrote:

[...]

> Yes, I made a stupid mistake. I hope it is fixed now, but it might be
> necessary to delete the remote calendars and sync anew. Sorry for that.

Thanks!  Works just fine now.  I didn't have to delete anything luckily.
-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.2, Org release_8.2.6-1021-g2ce78e