Re: Org 8 Bug in interactive formula editing mode?

[Nick Dokos <ndokos@gmail.com>]

Nick Dokos <ndokos@gmail.com> writes:

> Robert Klein <roklein@roklein.de> writes:
>
>> I made some quick tests with different org versions; the first one I see
>> this issue is git commit 30220ffcdcef45c0237f80a2347d4da19877f64a
>> (release_8.2.6-77-g30220f).
>>
>> I don't see the patch causing this, yet; have to look further.
>>
>
> Absolutely right, that looks like the culprit:
>
> ,----
> | commit 30220ffcdcef45c0237f80a2347d4da19877f64a
> | Author: Bastien Guerry <bzg@altern.org>
> | Date:   Thu Jun 12 12:04:24 2014 +0200
> | 
> |     Prefer `set-window-start' over `recenter' in some places.
> |     
> |     * org-agenda.el (org-agenda-show-1):
> |     * org-table.el (org-table-show-reference):   <<<<<<<<<<<<<< this change
> |     * org.el (org-fix-ellipsis-at-bol)
> |     (org-first-headline-recenter): Use `set-window-start' instead
> |     of `recenter'.
> |     
> |     * org-agenda.el (org-recenter-heading): Delete.
> `----

The diff was

,----
| diff --git a/lisp/org-table.el b/lisp/org-table.el
| index 1d6bee0..6d649ab 100644
| --- a/lisp/org-table.el
| +++ b/lisp/org-table.el
| @@ -3863,9 +3863,10 @@ With prefix ARG, apply the new formulas to the table."
|  	(push org-table-current-begin-pos org-show-positions)
|  	(let ((min (apply 'min org-show-positions))
|  	      (max (apply 'max org-show-positions)))
| -	  (goto-char min) (recenter 0)
| +	  (set-window-start (selected-window) (point-min))
|  	  (goto-char max)
| -	  (or (pos-visible-in-window-p max) (recenter -1))))
| +	  (or (pos-visible-in-window-p max)
| +	      (set-window-start (selected-window) (point-max)))))
|        (select-window win))))
|  
|  (defun org-table-force-dataline ()
`----

I suspect that instead of (point-min), it should be just min
and instead of point-max, it should be just max (or possibly
the beginning of the next line if it exists).

Nick