From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Org 8 Bug in interactive formula editing mode? Date: Tue, 22 Jul 2014 16:48:01 -0400 Message-ID: <874my9azni.fsf@alphaville.bos.redhat.com> References: <20140721090925.73e90201@rudi> <20140721155003.52846bb4@rudi> <87k3763jcc.fsf@alphaville.bos.redhat.com> <20140721181458.7e8004db@rudi> <87ppgy1vfx.fsf@alphaville.bos.redhat.com> <20140721203626.2a5294c7@rudi> <20140721211725.2a7cd8c3@rudi> <20140721213627.180c865f@rudi> <53CE0434.4040805@roklein.de> <20140722101445.34ada66d@rudi> <87egxd6a7u.fsf@alphaville.bos.redhat.com> <20140722190935.03dfdf68@rudi> <871ttd5m4c.fsf@alphaville.bos.redhat.com> <87egxdb4kg.fsf@alphaville.bos.redhat.com> <53CEBBAC.9000402@roklein.de> <87a981b0g3.fsf@alphaville.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9gz1-0005IK-SQ for emacs-orgmode@gnu.org; Tue, 22 Jul 2014 16:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9gyw-0005jq-Al for emacs-orgmode@gnu.org; Tue, 22 Jul 2014 16:48:23 -0400 Received: from plane.gmane.org ([80.91.229.3]:37367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9gyw-0005jc-3f for emacs-orgmode@gnu.org; Tue, 22 Jul 2014 16:48:18 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1X9gyt-0004Ws-PM for emacs-orgmode@gnu.org; Tue, 22 Jul 2014 22:48:15 +0200 Received: from nat-pool-bos-t.redhat.com ([66.187.233.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 22 Jul 2014 22:48:15 +0200 Received: from ndokos by nat-pool-bos-t.redhat.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 22 Jul 2014 22:48:15 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nick Dokos writes: > Robert Klein writes: > >> I made some quick tests with different org versions; the first one I see >> this issue is git commit 30220ffcdcef45c0237f80a2347d4da19877f64a >> (release_8.2.6-77-g30220f). >> >> I don't see the patch causing this, yet; have to look further. >> > > Absolutely right, that looks like the culprit: > > ,---- > | commit 30220ffcdcef45c0237f80a2347d4da19877f64a > | Author: Bastien Guerry > | Date: Thu Jun 12 12:04:24 2014 +0200 > | > | Prefer `set-window-start' over `recenter' in some places. > | > | * org-agenda.el (org-agenda-show-1): > | * org-table.el (org-table-show-reference): <<<<<<<<<<<<<< this change > | * org.el (org-fix-ellipsis-at-bol) > | (org-first-headline-recenter): Use `set-window-start' instead > | of `recenter'. > | > | * org-agenda.el (org-recenter-heading): Delete. > `---- The diff was ,---- | diff --git a/lisp/org-table.el b/lisp/org-table.el | index 1d6bee0..6d649ab 100644 | --- a/lisp/org-table.el | +++ b/lisp/org-table.el | @@ -3863,9 +3863,10 @@ With prefix ARG, apply the new formulas to the table." | (push org-table-current-begin-pos org-show-positions) | (let ((min (apply 'min org-show-positions)) | (max (apply 'max org-show-positions))) | - (goto-char min) (recenter 0) | + (set-window-start (selected-window) (point-min)) | (goto-char max) | - (or (pos-visible-in-window-p max) (recenter -1)))) | + (or (pos-visible-in-window-p max) | + (set-window-start (selected-window) (point-max))))) | (select-window win)))) | | (defun org-table-force-dataline () `---- I suspect that instead of (point-min), it should be just min and instead of point-max, it should be just max (or possibly the beginning of the next line if it exists). Nick