From: Marco Wahl <marcowahlsoft@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: Bastien <bzg@gnu.org>,
"Juan Manuel Macías" <maciaschain@posteo.net>,
orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix some typos
Date: Wed, 29 Sep 2021 13:09:05 +0200 [thread overview]
Message-ID: <8735pnwsdq.fsf@gmail.com> (raw)
In-Reply-To: <8a4d2326-c25f-eefb-9d16-9d108df1e247@gmail.com> (Max Nikulin's message of "Wed, 29 Sep 2021 17:34:34 +0700")
Max Nikulin <manikulin@gmail.com> writes:
> Bastien,
>
> A message in this thread
> https://orgmode.org/list/87tuiaxivh.fsf@posteo.net/ (Juan Manuel
> Macías, Fri, 24 Sep 2021 12:23:14 +0000) contains a patch that fixes a
> Shakespeare's sonnet in org-manual.org
>
> Due to updated ORG-NEWS file, it could not be applied directly. I had
> it applied after
>
> commit d74a82448bc28dd9be7b57611038bbb4c7172bce
> Author: Sébastien Miquel <sebastien.miquel@posteo.eu>
> Date: Fri May 28 21:14:22 2021 +0200
>
> and in such form it could be rebased to main. Alternatively ORG-NEWS
> part could be just dropped (and applied later).
>
> The story is the following:
> - 91373e15c8 doc/org-manual.org 13905 (Juan Manuel Macías
> 2021-05-15 15:44:36 +0200 13906)
> a documentation for verse formatting was added with a strange variant
> (spread over net though)
> - 215d80d02b doc/org-manual.org 13907 (Stefan Kangas 2021-09-16
> 14:40:12 -0700 13909)
> besides other typos, one in this verse was fixed
> - 4271f228db doc/org-manual.org 13909 (Marco Wahl 2021-09-20
> 12:09:31 +0200 13909)
> reverted one edit by Stefan likely assuming old English spelling.
>
> Nobody has an idea concerning origin of current variant (particular
> edition of Shakespeare's book), so Juan Manuel created the patch with
> variant published in recent books.
>
> In https://orgmode.org/list/sin28h$ufv$1@ciao.gmane.io/
> I tried to add the following header
> X-Woof-Patch: org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and
> another typo
> but the patch is not tracked currently on updates.orgmode.org
>
> On 25/09/2021 18:08, Marco Wahl wrote:
>> Juan Manuel Macías writes:
>>
>>> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
>>> replaced by the version included in Wikipedia (Shakespeare, William.
>>> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
>>> p. 113). I also removed a spurious phrase that I put in that patch
>>> (Org-News).
>> Thanks for the fix of the ORGNEWS entry. Nitpick: I'd prefer the
>> fix of
>> the ORGNEWS in a further patch for a little bit of more clarity.
>
> I agree with such remark, however I still suppose that the patch could
> be applied even in current variant.
Please go ahead with the patches as you like! That nitpick is meant as
a hint for commits to come!
Regards,
--
Marco
next prev parent reply other threads:[~2021-09-29 11:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 21:40 [PATCH] Fix some typos Stefan Kangas
2021-09-17 9:03 ` Timothy
2021-09-17 10:05 ` Marco Wahl
2021-09-17 10:26 ` Stefan Kangas
2021-09-22 16:47 ` Max Nikulin
2021-09-22 20:18 ` Juan Manuel Macías
2021-09-23 14:49 ` Max Nikulin
2021-09-24 6:03 ` Loris Bennett
2021-09-24 12:23 ` Juan Manuel Macías
2021-09-25 11:08 ` Marco Wahl
2021-09-29 10:34 ` Max Nikulin
2021-09-29 11:09 ` Marco Wahl [this message]
2021-09-29 11:11 ` Bastien Guerry
2021-09-25 11:47 ` [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo Max Nikulin
2021-09-29 11:14 ` [PATCH] Fix some typos Bastien
2021-09-23 10:25 ` Marco Wahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735pnwsdq.fsf@gmail.com \
--to=marcowahlsoft@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=maciaschain@posteo.net \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).