* Clear image cache
@ 2010-05-20 16:45 Russell Adams
2010-05-20 22:14 ` Dan Davison
0 siblings, 1 reply; 9+ messages in thread
From: Russell Adams @ 2010-05-20 16:45 UTC (permalink / raw)
To: emacs-orgmode
FYI,
I just updated to 6.36c and still have the issue of cached images not
refreshing. I had to apply this patch from the ML, which fixed it.
Love those inline R graphs!
Thanks.
--- org.el~ 2010-05-13 13:10:48.000000000 -0500
+++ org.el 2010-05-20 10:12:45.000000000 -0500
@@ -15506,6 +15506,7 @@
(defun org-remove-inline-images ()
"Remove inline display of images."
(interactive)
+ (clear-image-cache)
(mapc 'delete-overlay org-inline-image-overlays)
(setq org-inline-image-overlays nil))
------------------------------------------------------------------
Russell Adams RLAdams@AdamsInfoServ.com
PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Clear image cache
2010-05-20 16:45 Clear image cache Russell Adams
@ 2010-05-20 22:14 ` Dan Davison
2010-05-20 22:25 ` John Wiegley
0 siblings, 1 reply; 9+ messages in thread
From: Dan Davison @ 2010-05-20 22:14 UTC (permalink / raw)
To: emacs-orgmode
Russell Adams <RLAdams@AdamsInfoServ.Com> writes:
> FYI,
>
> I just updated to 6.36c and still have the issue of cached images not
> refreshing. I had to apply this patch from the ML, which fixed it.
Hi Russell,
This issue was supposed to have been fixed by commit
14449202535562b3d3d91c753fdead00a64caa79, see
http://article.gmane.org/gmane.emacs.orgmode/25149
Indeed, I am getting automatic refresh of R images.
My understanding is that 6.36 corresponds to
d56d417bc214088114e10c959ce78bee2d26635d and therefore should include
the above commit.
Could you double check that you don't have a stale org.elc?
Dan
>
> Love those inline R graphs!
>
> Thanks.
>
> --- org.el~ 2010-05-13 13:10:48.000000000 -0500
> +++ org.el 2010-05-20 10:12:45.000000000 -0500
> @@ -15506,6 +15506,7 @@
> (defun org-remove-inline-images ()
> "Remove inline display of images."
> (interactive)
> + (clear-image-cache)
> (mapc 'delete-overlay org-inline-image-overlays)
> (setq org-inline-image-overlays nil))
>
>
> ------------------------------------------------------------------
> Russell Adams RLAdams@AdamsInfoServ.com
>
> PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
>
> Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: Clear image cache
2010-05-20 22:14 ` Dan Davison
@ 2010-05-20 22:25 ` John Wiegley
2010-05-21 3:06 ` Russell Adams
0 siblings, 1 reply; 9+ messages in thread
From: John Wiegley @ 2010-05-20 22:25 UTC (permalink / raw)
To: Dan Davison; +Cc: emacs-orgmode
On May 20, 2010, at 6:14 PM, Dan Davison wrote:
> This issue was supposed to have been fixed by commit
> 14449202535562b3d3d91c753fdead00a64caa79, see
Russell's patch was just applied, let me know if it is unnecessary and should be reverted.
John
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: Clear image cache
2010-05-20 22:25 ` John Wiegley
@ 2010-05-21 3:06 ` Russell Adams
2010-05-21 3:41 ` Dan Davison
0 siblings, 1 reply; 9+ messages in thread
From: Russell Adams @ 2010-05-21 3:06 UTC (permalink / raw)
To: emacs-orgmode
FYI,
That was from a ML post, I cannot take credit. Thanks to who posted
it, it helped me out!
In response to the other, I just downloaded 6.36c from the website
*today* and had to apply that patch to make it work.
Thanks.
On Thu, May 20, 2010 at 06:25:26PM -0400, John Wiegley wrote:
> On May 20, 2010, at 6:14 PM, Dan Davison wrote:
>
> > This issue was supposed to have been fixed by commit
> > 14449202535562b3d3d91c753fdead00a64caa79, see
>
> Russell's patch was just applied, let me know if it is unnecessary and should be reverted.
>
> John
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
------------------------------------------------------------------
Russell Adams RLAdams@AdamsInfoServ.com
PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Clear image cache
2010-05-21 3:06 ` Russell Adams
@ 2010-05-21 3:41 ` Dan Davison
2010-05-21 3:59 ` Nick Dokos
2010-05-21 9:01 ` John Wiegley
0 siblings, 2 replies; 9+ messages in thread
From: Dan Davison @ 2010-05-21 3:41 UTC (permalink / raw)
To: emacs-orgmode
Russell Adams <RLAdams@AdamsInfoServ.Com> writes:
> FYI,
>
> That was from a ML post, I cannot take credit. Thanks to who posted
> it, it helped me out!
No problem.
> In response to the other, I just downloaded 6.36c from the website
> *today* and had to apply that patch to make it work.
OK, that makes sense, as I've just downloaded the 6.36c tarball to check
and it does not contain the commit in question (144492025355).
[...]
>> > This issue was supposed to have been fixed by commit
>> > 14449202535562b3d3d91c753fdead00a64caa79, see
>>
>> Russell's patch was just applied, let me know if it is unnecessary and should be reverted.
So, John -- yes, could you revert that please as the issue has been
fixed subsequent to 6.36.
Could someone tell me how to find out which commit corresponds to a
certain release (e.g. 6.36c)?
Dan
>>
>> John
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>
> ------------------------------------------------------------------
> Russell Adams RLAdams@AdamsInfoServ.com
>
> PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
>
> Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: Clear image cache
2010-05-21 3:41 ` Dan Davison
@ 2010-05-21 3:59 ` Nick Dokos
2010-05-21 9:01 ` John Wiegley
1 sibling, 0 replies; 9+ messages in thread
From: Nick Dokos @ 2010-05-21 3:59 UTC (permalink / raw)
To: Dan Davison; +Cc: nicholas.dokos, emacs-orgmode
Dan Davison <davison@stats.ox.ac.uk> wrote:
> Could someone tell me how to find out which commit corresponds to a
> certain release (e.g. 6.36c)?
>
Do ``git fetch --tags'', then ``git tag'' to see the list of tags:
...
release_6.35i
release_6.36
release_6.36c
test_5.21_tagging
Then ``git show release_6.36c'':
,----
| $ git show release_6.36c
| commit 4e128323d4631f73627693db88cd30a4ff083bf6
| Author: Carsten Dominik <carsten.dominik@gmail.com>
| Date: Thu May 13 19:52:16 2010 +0200
|
| Release 6.36c
|
| diff --git a/README_DIST b/README_DIST
| index 22392e3..8b7b933 100644
| --- a/README_DIST
| +++ b/README_DIST
| @@ -1,7 +1,7 @@
| ...
`----
HTH,
Nick
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Clear image cache
2010-05-21 3:41 ` Dan Davison
2010-05-21 3:59 ` Nick Dokos
@ 2010-05-21 9:01 ` John Wiegley
2010-05-21 13:38 ` Tassilo Horn
1 sibling, 1 reply; 9+ messages in thread
From: John Wiegley @ 2010-05-21 9:01 UTC (permalink / raw)
To: Dan Davison; +Cc: emacs-orgmode
On May 20, 2010, at 11:41 PM, Dan Davison wrote:
> So, John -- yes, could you revert that please as the issue has been
> fixed subsequent to 6.36.
Done.
John
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Clear image cache
2010-05-21 9:01 ` John Wiegley
@ 2010-05-21 13:38 ` Tassilo Horn
2010-05-21 15:01 ` John Wiegley
0 siblings, 1 reply; 9+ messages in thread
From: Tassilo Horn @ 2010-05-21 13:38 UTC (permalink / raw)
To: emacs-orgmode
John Wiegley <jwiegley@gmail.com> writes:
>> So, John -- yes, could you revert that please as the issue has been
>> fixed subsequent to 6.36.
>
> Done.
Out of interested: is patchwork integrated with the git repo, so that it
could automatically check if a patch was applied? And even better: see
that this patch was now reverted and thus shouldn't be listed as
"accepted" anymore?
Bye,
Tassilo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: Clear image cache
2010-05-21 13:38 ` Tassilo Horn
@ 2010-05-21 15:01 ` John Wiegley
0 siblings, 0 replies; 9+ messages in thread
From: John Wiegley @ 2010-05-21 15:01 UTC (permalink / raw)
To: Tassilo Horn; +Cc: emacs-orgmode
On May 21, 2010, at 9:38 AM, Tassilo Horn wrote:
> Out of interested: is patchwork integrated with the git repo, so that it
> could automatically check if a patch was applied? And even better: see
> that this patch was now reverted and thus shouldn't be listed as
> "accepted" anymore?
No, it is not interested. But you just reminded to go mark it rejected. :)
John
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-05-21 15:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-20 16:45 Clear image cache Russell Adams
2010-05-20 22:14 ` Dan Davison
2010-05-20 22:25 ` John Wiegley
2010-05-21 3:06 ` Russell Adams
2010-05-21 3:41 ` Dan Davison
2010-05-21 3:59 ` Nick Dokos
2010-05-21 9:01 ` John Wiegley
2010-05-21 13:38 ` Tassilo Horn
2010-05-21 15:01 ` John Wiegley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).