Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

[wgg2]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Hello,

On the latest `org-plus-contrib' build from the org package.el repo, my
Agenda buffers (for any Agenda command) fail to render properly, with
these pertinent lines from *Backtrace*:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
  put-text-property(28484 nil org-appt-warntime "60")
  org-refresh-properties("APPT_WARNTIME" org-appt-warntime)
  (or (memq (quote appt) org-agenda-ignore-drawer-properties) (org-refresh-properties "APPT_WARNTIME" (quote org-appt-warntime)))
--8<---------------cut here---------------end--------------->8---

I first attempted to deactivate all use of the appt library in my Emacs,
including my setting of agenda-mode-hook which previously had called
`org-agenda-to-appt'. Still the Agenda would not render correctly.

I then isolated this to the following lines of function
`org-agenda-prepare-buffers':

--8<---------------cut here---------------start------------->8---
	    (or (memq 'appt org-agenda-ignore-drawer-properties)
	        (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime))
--8<---------------cut here---------------end--------------->8---

With these lines commented out, my Agenda buffer was able to load
correctly.

Best,
WGG


Emacs  : GNU Emacs 24.3.1 (x86_64-slackware-linux-gnu)
 of 2014-03-13 on motoko
Package: Org-mode version 8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)

current state:
==============
(setq
 org-id-locations-file "~/org/.org-id-locations"
 org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-latex-classes '(("memoir-MSWordish"
                      "\\documentclass[12pt,article,oneside]{memoir}\n\\usepackage{times}\n\\usepackage{indentfirst}\n\\usepackage[left=1in,right=1in,top=1in,bottom=1in]{geometry}\n\\linespread{1.6}"
                      ("\\chapter{%s}" . "\\chapter*{%s}") ("\\section{%s}" . "\\section*{%s}") ("\\subsection{%s}" . "\\subsection*{%s}")
                      ("\\subsubsection{%s}" . "\\subsubsection*{%s}") ("\\paragraph{%s}" . "\\paragraph*{%s}"))
                     ("beamer" "\\documentclass{beamer}" org-beamer-sectioning)
                     ("my-letter"
                      "\\documentclass[fromalign=left,backaddress=false]{scrlttr2}\n\\usepackage[english]{babel}\n\\usepackage{times}\n\\usepackage{indentfirst}\n\\usepackage[left=1in,right=1in,top=1in,bottom=1in]{geometry}\n\\linespread{1.6}")
                     ("memoir-helvetica"
                      "\\documentclass[12pt,article,oneside]{memoir}\n\\usepackage{helvet}\n\\renewcommand*{\\familydefault}{\\sfdefault}\n\\usepackage{indentfirst}\n\\usepackage[left=1in,right=1in,top=1in,bottom=1in]{geometry}\n\\linespread{1.6}"
                      ("\\chapter{%s}" . "\\chapter*{%s}") ("\\section{%s}" . "\\section*{%s}") ("\\subsection{%s}" . "\\subsection*{%s}")
                      ("\\subsubsection{%s}" . "\\subsubsection*{%s}") ("\\paragraph{%s}" . "\\paragraph*{%s}"))
                     ("memoir-MSWordish-tiny"
                      "\\documentclass[10pt,article,oneside]{memoir}\n\\usepackage{times}\n\\usepackage{indentfirst}\n\\usepackage[left=1in,right=1in,top=1in,bottom=1in]{geometry}"
                      ("\\chapter{%s}" . "\\chapter*{%s}") ("\\section{%s}" . "\\section*{%s}") ("\\subsection{%s}" . "\\subsection*{%s}")
                      ("\\subsubsection{%s}" . "\\subsubsection*{%s}") ("\\paragraph{%s}" . "\\paragraph*{%s}"))
                     )
 org-footnote-section nil
 org-latex-default-packages-alist '(("utf8" "inputenc" t) ("T1" "fontenc" t) ("" "fixltx2e" nil) ("" "graphicx" t) ("" "longtable" nil) ("" "float" nil)
                                    ("" "wrapfig" nil) ("normalem" "ulem" t) ("" "textcomp" t) ("" "marvosym" t) ("" "wasysym" t) ("" "latexsym" t)
                                    ("" "amssymb" t) ("" "amstext" nil) ("" "hyperref" nil) "\\tolerance=1000")
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-gnus-prefer-web-links t
 org-agenda-diary-file "~/org/Diary.org"
 org-occur-hook '(org-first-headline-recenter)
 org-src-tab-acts-natively t
 org-imenu-depth 4
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-html-format-drawer-function '(lambda (name contents) contents)
 org-latex-format-inlinetask-function 'ignore
 org-confirm-shell-link-function 'yes-or-no-p
 org-id-link-to-org-use-id t
 org-columns-default-format "%40ITEM %10TODO %10Effort\n      %20TAGS"
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-export-with-date nil
 org-export-with-section-numbers nil
 org-export-with-toc nil
 org-agenda-prefix-format '((agenda . " %i %-12:c%?-12t% s") (timeline . " %b % s") (todo . " %i %-12:c") (tags . " %i %-12:c") (search . " %i %-12:c"))
 org-agenda-custom-commands '(("n" "Agenda and all TODO's" ((agenda "" nil) (alltodo "" nil)) nil))
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-agenda-include-diary t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-latex-format-drawer-function '(lambda (name contents) contents)
 org-odt-format-headline-function 'ignore
 org-capture-mode-hook '(wg/fix-capture-indentation)
 org-from-is-user-regexp "\\<W\\. Greenhouse\\>"
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(turn-on-flyspell auto-fill-mode #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
                 #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-refile-targets '((nil :maxlevel . 9) (org-agenda-files :maxlevel . 2))
 org-outline-path-complete-in-steps nil
 org-use-speed-commands t
 org-ascii-format-drawer-function '(lambda (name contents width) contents)
 org-odt-format-inlinetask-function 'ignore
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
 org-refile-use-outline-path 'file
 org-timer-done-hook '(ding)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-hide-inline-tasks org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-attach-store-link-p t
 org-export-with-author nil
 org-export-async-init-file "/home/wgg/.emacs.d/init.elc"
 org-modules '(org-habit org-w3m org-bbdb org-bibtex org-docview org-gnus org-info org-irc org-mhe org-rmail)
 org-agenda-window-setup 'current-window
 org-timer-default-timer 25
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-log-into-drawer t
 org-odt-format-drawer-function '(lambda (name contents) contents)
 org-latex-default-class "memoir-MSWordish"
 org-html-format-headline-function 'ignore
 org-export-with-smart-quotes t
 org-completion-use-ido t
 org-html-format-inlinetask-function 'ignore
 org-agenda-files '("~/org")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-link-frame-setup '((vm . vm-visit-folder-other-frame) (vm-imap . vm-visit-imap-folder-other-frame) (gnus . org-gnus-no-new-news) (file . find-file)
                        (wl . wl-other-frame))
 org-src-fontify-natively t
 )

[PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

[Sacha Chua]

wgg2@member.fsf.org writes:

> On the latest `org-plus-contrib' build from the org package.el repo, my
> Agenda buffers (for any Agenda command) fail to render properly, with
> these pertinent lines from *Backtrace*:
> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
>   put-text-property(28484 nil org-appt-warntime "60")
...
> I then isolated this to the following lines of function
> `org-agenda-prepare-buffers':
> 	    (or (memq 'appt org-agenda-ignore-drawer-properties)
> 	        (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime))

I ran into a similar problem with org-agenda-prepare-buffers and the
EFFORT property. This change to org-refresh-properties seems to fix it:

diff --git a/lisp/org.el b/lisp/org.el
index f8615a2..bd9c05e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9393,7 +9393,7 @@ property to set."
 	   (save-excursion
 	     (org-back-to-heading t)
 	     (put-text-property
-	      (point-at-bol) (outline-next-heading) tprop p))))))))
+	      (point-at-bol) (or (outline-next-heading) (point-max)) tprop p))))))))
 
 
 ;;;; Link Stuff

The previous version by Bastien used (org-end-of-subtree t t), which had
checked for (eobp) in it, but outline-next-heading returns nil if there
are no further headings.

Sacha Chua

Re: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

[W. Greenhouse]

Sacha Chua <sacha-bc55NVWLdWuB+jHODAdFcQ@public.gmane.org> writes:
>
> I ran into a similar problem with org-agenda-prepare-buffers and the
> EFFORT property. This change to org-refresh-properties seems to fix it:

Awesome, thanks. :)

This patch is still needed (and works) as of the ELPA build from org
8.2.5h, commit g0820d0.

--
Best,
WGG

Re: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

[Bastien]

Hi Sacha,

Sacha Chua <sacha@sachachua.com> writes:

> I ran into a similar problem with org-agenda-prepare-buffers and the
> EFFORT property. This change to org-refresh-properties seems to fix
> it:

Applied in maint, thanks a lot!

-- 
 Bastien