From: Sacha Chua <sacha@sachachua.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]
Date: Sat, 05 Apr 2014 14:28:09 -0400 [thread overview]
Message-ID: <86fvlrfx6u.fsf@sachachua.com> (raw)
In-Reply-To: 871txmsz92.fsf@motoko.kusanagi
wgg2@member.fsf.org writes:
> On the latest `org-plus-contrib' build from the org package.el repo, my
> Agenda buffers (for any Agenda command) fail to render properly, with
> these pertinent lines from *Backtrace*:
> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
> put-text-property(28484 nil org-appt-warntime "60")
...
> I then isolated this to the following lines of function
> `org-agenda-prepare-buffers':
> (or (memq 'appt org-agenda-ignore-drawer-properties)
> (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime))
I ran into a similar problem with org-agenda-prepare-buffers and the
EFFORT property. This change to org-refresh-properties seems to fix it:
diff --git a/lisp/org.el b/lisp/org.el
index f8615a2..bd9c05e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9393,7 +9393,7 @@ property to set."
(save-excursion
(org-back-to-heading t)
(put-text-property
- (point-at-bol) (outline-next-heading) tprop p))))))))
+ (point-at-bol) (or (outline-next-heading) (point-max)) tprop p))))))))
;;;; Link Stuff
The previous version by Bastien used (org-end-of-subtree t t), which had
checked for (eobp) in it, but outline-next-heading returns nil if there
are no further headings.
Sacha Chua
next prev parent reply other threads:[~2014-04-05 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 23:02 Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)] wgg2
2014-04-05 18:28 ` Sacha Chua [this message]
2014-04-07 13:52 ` [PATCH] " W. Greenhouse
2014-04-11 9:29 ` Bastien
-- strict thread matches above, loose matches on Subject: below --
2014-04-07 18:16 Jonathan Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fvlrfx6u.fsf@sachachua.com \
--to=sacha@sachachua.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).