emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Unclear org-icompleting-read interface
@ 2015-06-25 13:15 Oleh Krehel
  2015-06-25 13:51 ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Oleh Krehel @ 2015-06-25 13:15 UTC (permalink / raw)
  To: emacs-orgmode


Hi all,

The current `org-icompleting-read' is defined as taking only `&rest
args', which can be as many as 8, all of them without a name.

I propose to update the definition to:

    (cl-defun org-icompleting-read (prompt collection
                                    &key predicate require-match
                                      initial-input hist def inherit-input-method)
      ;; ...
      )

Let me know if you like the idea. If so, there are 43 calls to
`org-icompleting-read' in the source that need to be updated. Some of
them should as they are, since usually only the first two arguments are
used.

This change would make the calls to `org-icompleting-read' much easier
to read.

regards,
Oleh

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-06-25 16:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-25 13:15 Unclear org-icompleting-read interface Oleh Krehel
2015-06-25 13:51 ` Nicolas Goaziou
2015-06-25 14:23   ` Oleh Krehel
2015-06-25 14:36   ` Rasmus
2015-06-25 16:30     ` Nicolas Goaziou
2015-06-25 16:39       ` Rasmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).