Issue when jumping from agenda view to clock line

Issue when jumping from agenda view to clock line

[Francesco Pizzolante]

Hi,

I'm having an issue when jumping from the C-c a a / v c view (check log view
in the agenda view) to a clock line.

Here's a small example.

#+begin_src org
* My tasks

** First task
   :LOGBOOK:
   CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] =>  1:00
   CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] =>  1:00
   CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] =>  1:00
   :END:
#+end_src

In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
press ENTER on the log line for "First task", you jump to the corresponding
heading (First task) but it positions the cursor just after the :LOGBOOK:
keyword and the drawer remains closed.

The previous and correct behaviour was to jump to the corresponding line (in
the example, the third clock line) in the opened drawer.

I'm using org-mode version 7.9.2 (release_7.9.2-53-g93040f).

Thanks for your help.

Francesco

Re: Issue when jumping from agenda view to clock line

[Sebastien Vauban]

Hello Francesco,

"Francesco Pizzolante" wrote:
> I'm having an issue when jumping from the C-c a a / v c view (check log view
> in the agenda view) to a clock line.
>
> Here's a small example.
>
> #+begin_src org
> * My tasks
>
> ** First task
>    :LOGBOOK:
>    CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] =>  1:00
>    CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] =>  1:00
>    CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] =>  1:00
>    :END:
> #+end_src
>
> In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
> press ENTER on the log line for "First task", you jump to the corresponding
> heading (First task) but it positions the cursor just after the :LOGBOOK:
> keyword and the drawer remains closed.
>
> The previous and correct behaviour was to jump to the corresponding line (in
> the example, the third clock line) in the opened drawer.
>
> I'm using org-mode version 7.9.2 (release_7.9.2-53-g93040f).

I confirm having observed this regression as well (over the last month or so).

Best regards,
  Seb

-- 
Sebastien Vauban

Re: Issue when jumping from agenda view to clock line

[Bastien]

Hi Sébastien,

"Sebastien Vauban"
<wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:

>> I'm using org-mode version 7.9.2 (release_7.9.2-53-g93040f).
>
> I confirm having observed this regression as well (over the last
> monthor so).

I can't confirm this with latest Org (from master).

See http://lumiere.ens.fr/~guerry/u/orgbug.ogv for what
I tested.

Do I miss something?

-- 
 Bastien

Re: Issue when jumping from agenda view to clock line

[Sebastien Vauban]

Hello Bastien,

"Sebastien Vauban" wrote:
> "Francesco Pizzolante" wrote:
>> I'm having an issue when jumping from the C-c a a / v c view (check log view
>> in the agenda view) to a clock line.
>>
>> Here's a small example.
>>
>> #+begin_src org
>> * My tasks
>>
>> ** First task
>>    :LOGBOOK:
>>    CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] =>  1:00
>>    CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] =>  1:00
>>    CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] =>  1:00
>>    :END:
>> #+end_src
>>
>> In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
>> press ENTER on the log line for "First task", you jump to the corresponding
>> heading (First task) but it positions the cursor just after the :LOGBOOK:
>> keyword and the drawer remains closed.
>>
>> The previous and correct behaviour was to jump to the corresponding line (in
>> the example, the third clock line) in the opened drawer.
>>
>> I'm using org-mode version 7.9.2 (release_7.9.2-53-g93040f).
>
> I confirm having observed this regression as well (over the last month or so).

Please find a screencast here:

http://screencast.com/t/boqQvh3YlcK

You see that, when jumping from an agenda line to the source Org buffer
(containing the clock line), I'm not arriving at the source clock line
anymore.

I'm back on the (collapsed) drawer, and have to find myself the right line to
edit...

Before, when jumping from an agenda clock line, we arrived exactly on that
line. We could easily change the beginning or end time, without searching
first for the right line.

Is this more clear?

Best regards,
  Seb

-- 
Sebastien Vauban

Re: Issue when jumping from agenda view to clock line

[Francesco Pizzolante]

Hi,

> Here's a small example.
>
> #+begin_src org
> * My tasks
>
> ** First task
>    :LOGBOOK:
>    CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] =>  1:00
>    CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] =>  1:00
>    CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] =>  1:00
>    :END:
> #+end_src
>
> In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
> press ENTER on the log line for "First task", you jump to the corresponding
> heading (First task) but it positions the cursor just after the :LOGBOOK:
> keyword and the drawer remains closed.

Just to let you know that I found the issue...

It was coming from the following code I was using (taken from Worg:
http://orgmode.org/worg/org-configs/org-hooks.html):

    ╭────
    │       ;; get a compact view during follow mode in the agenda
    │         (defun my-compact-follow ()
    │           "Make the view compact, then show the necessary minimum."
    │           (ignore-errors
    │             (save-excursion
    │               (while (org-up-heading-safe))
    │               (hide-subtree)))
    │           (let ((org-show-siblings nil)
    │                 (org-show-hierarchy-above t))
    │             (org-reveal))
    │           (save-excursion
    │             (org-back-to-heading t)
    │             (show-children)))
    │
    │        (add-hook 'org-agenda-after-show-hook 'my-compact-follow)
    ╰────

But I don't understand the cause of it.

Thanks,
 Francesco

Re: Issue when jumping from agenda view to clock line

[Sebastien Vauban]

Hello Francesco,

"Francesco Pizzolante" wrote:
>> Here's a small example.
>>
>> #+begin_src org
>> * My tasks
>>
>> ** First task
>>    :LOGBOOK:
>>    CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] =>  1:00
>>    CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] =>  1:00
>>    CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] =>  1:00
>>    :END:
>> #+end_src
>>
>> In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
>> press ENTER on the log line for "First task", you jump to the corresponding
>> heading (First task) but it positions the cursor just after the :LOGBOOK:
>> keyword and the drawer remains closed.
>
> Just to let you know that I found the issue...
>
> It was coming from the following code I was using (taken from Worg:
> http://orgmode.org/worg/org-configs/org-hooks.html):
>
>     ╭────
>     │       ;; get a compact view during follow mode in the agenda
>     │         (defun my-compact-follow ()
>     │           "Make the view compact, then show the necessary minimum."
>     │           (ignore-errors
>     │             (save-excursion
>     │               (while (org-up-heading-safe))
>     │               (hide-subtree)))
>     │           (let ((org-show-siblings nil)
>     │                 (org-show-hierarchy-above t))
>     │             (org-reveal))
>     │           (save-excursion
>     │             (org-back-to-heading t)
>     │             (show-children)))
>     │
>     │        (add-hook 'org-agenda-after-show-hook 'my-compact-follow)
>     ╰────
>
> But I don't understand the cause of it.

As I ran against the same problem, I've bisected Org in order to try and get
more info.

Git bisect identifies 1e73d2bbc3ce635928ddd234d16ac9332460aa72 as the first bad commit

--8<---------------cut here---------------start------------->8---
commit 1e73d2bbc3ce635928ddd234d16ac9332460aa72
Author: Bastien Guerry <bzg-whniv8GeeGkdnm+yROfE0A@public.gmane.org>
Date:   Fri Aug 10 10:08:58 2012 +0200

    org-agenda.el (org-agenda-switch-to): Run hooks in `org-agenda-after-show-hook'

    * org-agenda.el (org-agenda-switch-to): Run hooks in
    `org-agenda-after-show-hook'.

    Thanks to Jack Erwin for suggesting this.
--8<---------------cut here---------------end--------------->8---

The diff:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index a70e968..09e5eab 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7512,7 +7512,8 @@ at the text of the entry itself."
          (and (outline-next-heading)
               (org-flag-heading nil))) ; show the next heading
        (when (outline-invisible-p)
-         (show-entry))))))             ; display invisible text
+         (show-entry))                 ; display invisible text
+       (run-hooks 'org-agenda-after-show-hook)))))

 (defun org-agenda-goto-mouse (ev)
   "Go to the Org-mode file which contains the item at the mouse click."
--8<---------------cut here---------------end--------------->8---

`org-agenda-after-show-hook' is well referenced in there. That's clearly it!

Now, it'd be interesting to know whether:

- it should be removed?  or

- the customization (found on Worg) should be place in another hook (not run
  at that stage)?

Bastien?

Best regards,
Seb

-- 
Sebastien Vauban