From: "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: Issue when jumping from agenda view to clock line
Date: Mon, 19 Nov 2012 23:46:53 +0100 [thread overview]
Message-ID: <80ip91nrc2.fsf@somewhere.org> (raw)
In-Reply-To: 87boex91hv.fsf@somewhere.org
Hello Francesco,
"Francesco Pizzolante" wrote:
>> Here's a small example.
>>
>> #+begin_src org
>> * My tasks
>>
>> ** First task
>> :LOGBOOK:
>> CLOCK: [2012-10-22 Mon 13:00]--[2012-10-22 Mon 14:30] => 1:00
>> CLOCK: [2012-10-23 Tue 13:00]--[2012-10-23 Tue 14:30] => 1:00
>> CLOCK: [2012-10-24 Wed 13:00]--[2012-10-24 Wed 14:30] => 1:00
>> :END:
>> #+end_src
>>
>> In the agenda view (C-c a a) for Wed 24, enable the check view (v c), then
>> press ENTER on the log line for "First task", you jump to the corresponding
>> heading (First task) but it positions the cursor just after the :LOGBOOK:
>> keyword and the drawer remains closed.
>
> Just to let you know that I found the issue...
>
> It was coming from the following code I was using (taken from Worg:
> http://orgmode.org/worg/org-configs/org-hooks.html):
>
> ╭────
> │ ;; get a compact view during follow mode in the agenda
> │ (defun my-compact-follow ()
> │ "Make the view compact, then show the necessary minimum."
> │ (ignore-errors
> │ (save-excursion
> │ (while (org-up-heading-safe))
> │ (hide-subtree)))
> │ (let ((org-show-siblings nil)
> │ (org-show-hierarchy-above t))
> │ (org-reveal))
> │ (save-excursion
> │ (org-back-to-heading t)
> │ (show-children)))
> │
> │ (add-hook 'org-agenda-after-show-hook 'my-compact-follow)
> ╰────
>
> But I don't understand the cause of it.
As I ran against the same problem, I've bisected Org in order to try and get
more info.
Git bisect identifies 1e73d2bbc3ce635928ddd234d16ac9332460aa72 as the first bad commit
--8<---------------cut here---------------start------------->8---
commit 1e73d2bbc3ce635928ddd234d16ac9332460aa72
Author: Bastien Guerry <bzg-whniv8GeeGkdnm+yROfE0A@public.gmane.org>
Date: Fri Aug 10 10:08:58 2012 +0200
org-agenda.el (org-agenda-switch-to): Run hooks in `org-agenda-after-show-hook'
* org-agenda.el (org-agenda-switch-to): Run hooks in
`org-agenda-after-show-hook'.
Thanks to Jack Erwin for suggesting this.
--8<---------------cut here---------------end--------------->8---
The diff:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index a70e968..09e5eab 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7512,7 +7512,8 @@ at the text of the entry itself."
(and (outline-next-heading)
(org-flag-heading nil))) ; show the next heading
(when (outline-invisible-p)
- (show-entry)))))) ; display invisible text
+ (show-entry)) ; display invisible text
+ (run-hooks 'org-agenda-after-show-hook)))))
(defun org-agenda-goto-mouse (ev)
"Go to the Org-mode file which contains the item at the mouse click."
--8<---------------cut here---------------end--------------->8---
`org-agenda-after-show-hook' is well referenced in there. That's clearly it!
Now, it'd be interesting to know whether:
- it should be removed? or
- the customization (found on Worg) should be place in another hook (not run
at that stage)?
Bastien?
Best regards,
Seb
--
Sebastien Vauban
prev parent reply other threads:[~2012-11-19 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 15:07 Issue when jumping from agenda view to clock line Francesco Pizzolante
2012-10-25 8:35 ` Sebastien Vauban
2012-10-25 9:09 ` Bastien
2012-10-25 14:54 ` Sebastien Vauban
[not found] ` <87fw53syc9.fsf-oHC15RC7JGTNLxjTenLetw@public.gmane.org>
2012-11-16 12:27 ` Francesco Pizzolante
2012-11-19 22:46 ` Sebastien Vauban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ip91nrc2.fsf@somewhere.org \
--to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).