emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sébastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: [PATCH] Re: TODO state change from TODO to DONE blocked
Date: Fri, 04 Mar 2011 16:15:37 +0100	[thread overview]
Message-ID: <80d3m6rk6e.fsf_-_@somewhere.org> (raw)
In-Reply-To: 80hbbjq690.fsf@somewhere.org

Hi Bastien,

Sébastien Vauban wrote:
> Bastien wrote:
>>>> I've a really weird exception occurring: change state from TODO to DONE is
>>>> blocked... while I'm on a leaf of the Org tree!?
>>>>
>>>> Debugger entered--Lisp error: (error #("TODO state change from TODO to
>>>> DONE blocked" 23 27 (face org-todo) 31 35 (face org-done)))
>>
>> Are you using `org-blocker-hook' or `org-trigger-hook'?
>>
>> Let us know.
>
> Though, hopping from one variable description to another, I remembered that I
> had set the variable =org-enforce-todo-dependencies= to =t=. Trying to set it
> to =nil= made the problem disappear... So, it was a bit narrowed.
>
> I could see in the description of that var that it could block state change if
> tasks were ordered and a previous one not done. But I never use the ordered
> property.
>
> ... Well, never, but well in that parent tree. Was it for test purpose?  Did I
> have something else in mind?  I dunno anymore, but that property was
> definitely the culprit.
>
> Doing so, I'm wondering:
>
> - if the output message could be updated to make it clear what the reason is,
>   or can be?

diff --git a/lisp/org.el b/lisp/org.el
index 3a07cfd..fb60bc6 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10927,7 +10927,10 @@ For calling through lisp, arg is also interpreted in the following way:
 			(run-hook-with-args-until-failure
 			 'org-blocker-hook change-plist)))
 	      (if (interactive-p)
-		  (error "TODO state change from %s to %s blocked" this state)
+		  (error (concat "TODO state change from %s to %s blocked "
+				 "(because of undone child, or "
+				 "parent with ORDERED property and undone prior sibling)")
+			 this state)
 		;; fail silently
 		(message "TODO state change from %s to %s blocked" this state)
 		(throw 'exit nil))))

Best regards,
  Seb

-- 
Sébastien Vauban

  reply	other threads:[~2011-03-04 15:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 10:51 TODO state change from TODO to DONE blocked Sébastien Vauban
2011-02-24 16:04 ` Sébastien Vauban
2011-02-26 17:06   ` Bastien
2011-03-04 15:01     ` Sébastien Vauban
2011-03-04 15:15       ` Sébastien Vauban [this message]
2011-03-04 18:46         ` [PATCH] " Bastien
2011-03-04 21:54           ` Sébastien Vauban
2011-03-05 10:02             ` Bastien
2011-03-04 16:13       ` Bernt Hansen
2011-03-04 21:52         ` Sébastien Vauban
2011-03-05 10:03         ` Bastien
2011-03-05 11:10           ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80d3m6rk6e.fsf_-_@somewhere.org \
    --to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).