From: Bastien <bzg@altern.org>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: TODO state change from TODO to DONE blocked
Date: Fri, 04 Mar 2011 19:46:35 +0100 [thread overview]
Message-ID: <87sjv2bu5w.fsf@gnu.org> (raw)
In-Reply-To: <80d3m6rk6e.fsf_-_@somewhere.org> ("Sébastien Vauban"'s message of "Fri, 04 Mar 2011 16:15:37 +0100")
Hi Sébastien,
Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
>> - if the output message could be updated to make it clear what the reason is,
>> or can be?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3a07cfd..fb60bc6 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10927,7 +10927,10 @@ For calling through lisp, arg is also interpreted in the following way:
> (run-hook-with-args-until-failure
> 'org-blocker-hook change-plist)))
> (if (interactive-p)
> - (error "TODO state change from %s to %s blocked" this state)
> + (error (concat "TODO state change from %s to %s blocked "
> + "(because of undone child, or "
> + "parent with ORDERED property and undone prior sibling)")
> + this state)
I'm not in favor of displaying such a long error message: I find it not
easily readable, and it raises too many potential causes for the error.
The user already knows about these various reasons by reading the
docstring of `org-enforce-todo-dependencies', which defaults to `nil'.
Thanks anyway for the patch!
--
Bastien
next prev parent reply other threads:[~2011-03-04 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 10:51 TODO state change from TODO to DONE blocked Sébastien Vauban
2011-02-24 16:04 ` Sébastien Vauban
2011-02-26 17:06 ` Bastien
2011-03-04 15:01 ` Sébastien Vauban
2011-03-04 15:15 ` [PATCH] " Sébastien Vauban
2011-03-04 18:46 ` Bastien [this message]
2011-03-04 21:54 ` Sébastien Vauban
2011-03-05 10:02 ` Bastien
2011-03-04 16:13 ` Bernt Hansen
2011-03-04 21:52 ` Sébastien Vauban
2011-03-05 10:03 ` Bastien
2011-03-05 11:10 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjv2bu5w.fsf@gnu.org \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).