Re: Re: Support (or not) for Emacs 21, and XEmacs

[Carsten Dominik <carsten.dominik@gmail.com>]

On Apr 19, 2010, at 1:19 PM, Michael Sperber wrote:

>
> One more thing: Are patches like this one acceptable? (Needed to make
> yesterday's checkout work on XEmacs)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 7cad962..5cca11e 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -17743,7 +17743,7 @@ the functionality can be provided as a fall- 
> back.")
>   (org-set-local 'fill-paragraph-function 'org-fill-paragraph)
>   ;; Adaptive filling: To get full control, first make sure that
>   ;; `adaptive-fill-regexp' never matches.  Then install our own  
> matcher.
> -  (unless (local-variable-p 'adaptive-fill-regexp)
> +  (unless (local-variable-p 'adaptive-fill-regexp (current-buffer))
>     (org-set-local 'org-adaptive-fill-regexp-backup
>                    adaptive-fill-regexp))
>   (org-set-local 'adaptive-fill-regexp "\000")

That is acceptable - but I think that making BUFFER default to  
(current-buffer)
does make a lot of sense - which is why making that argument optional  
in XEmacs
is a good idea anyway.

- Carsten