[PATCH] org-capture with LISP function template

[PATCH] org-capture with LISP function template

[Juan Pechiar]

Hi Carsten + crowd,

Below is a patch for org-capture when the template is given by a LISP
function.

Problem was that the function is inside a string (not a LISP form), so
the string has to be evaluated explicitly.

Now it's working for me. I use it to get a template formed by
URL/title and selected text from Opera browser (on Mac OSX). I´ll
publish this after polishing the code.

I've also been testing exotic org-capture templates and I've found no
other errors yet.

Best regards,
.j.

8<------------------------------------------------------------

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 2a3a1b8..409427f 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -440,8 +440,8 @@ bypassed."
          (setq txt (org-file-contents file))
        (setq txt (format "* Template file %s not found" (nth 1
        txt)))))
      ((and (listp txt) (eq (car txt) 'function))
-      (if (fboundp (nth 1 txt))
-         (setq txt (funcall (nth 1 txt)))
+      (if (eval (concat "fboundp " (nth 1 txt)))
+         (setq txt (eval (read (nth 1 txt))))
        (setq txt (format "* Template function %s not found" (nth 1
        txt)))))
      ((not txt) (setq txt ""))
      ((stringp txt))

Re: [PATCH] org-capture with LISP function template

[Carsten Dominik]

Hi Juan,

the function must be a symbol in this setup, not a string.
I am rejecting this patch.

Cheers.

- Carsten

On Jul 19, 2010, at 3:45 AM, Juan Pechiar wrote:

> Hi Carsten + crowd,
>
> Below is a patch for org-capture when the template is given by a LISP
> function.
>
> Problem was that the function is inside a string (not a LISP form), so
> the string has to be evaluated explicitly.
>
> Now it's working for me. I use it to get a template formed by
> URL/title and selected text from Opera browser (on Mac OSX). I´ll
> publish this after polishing the code.
>
> I've also been testing exotic org-capture templates and I've found no
> other errors yet.
>
> Best regards,
> .j.
>
> 8<------------------------------------------------------------
>
> diff --git a/lisp/org-capture.el b/lisp/org-capture.el
> index 2a3a1b8..409427f 100644
> --- a/lisp/org-capture.el
> +++ b/lisp/org-capture.el
> @@ -440,8 +440,8 @@ bypassed."
>          (setq txt (org-file-contents file))
>        (setq txt (format "* Template file %s not found" (nth 1
>        txt)))))
>      ((and (listp txt) (eq (car txt) 'function))
> -      (if (fboundp (nth 1 txt))
> -         (setq txt (funcall (nth 1 txt)))
> +      (if (eval (concat "fboundp " (nth 1 txt)))
> +         (setq txt (eval (read (nth 1 txt))))
>        (setq txt (format "* Template function %s not found" (nth 1
>        txt)))))
>      ((not txt) (setq txt ""))
>      ((stringp txt))

- Carsten

Re: Re: [PATCH] org-capture with LISP function template

[Juan]

Hi Carsten,

I think the original problem is in the defcustom specification:

org-capture.el L292

	   (choice :tag "Template"
		   (string)
		   (list :tag "File"
			 (const :format "" file)
			 (file :tag "Template file"))
		   (list :tag "Function"
			 (const :format "" function)
			 (file :tag "Template function")))

The last line should read 'sexp' instead of 'file'. This is why the
function is being held as a string.

Saludos,
.j.

On Mon, Jul 19, 2010 at 09:05:06AM +0200, Carsten Dominik wrote:
> the function must be a symbol in this setup, not a string.
> I am rejecting this patch.
>
> On Jul 19, 2010, at 3:45 AM, Juan Pechiar wrote:

> >Below is a patch for org-capture when the template is given by a LISP
> >function.
> >
> >Problem was that the function is inside a string (not a LISP form), so
> >the string has to be evaluated explicitly.

Re: Re: [PATCH] org-capture with LISP function template

[Carsten Dominik]

On Jul 19, 2010, at 2:26 PM, Juan wrote:

> Hi Carsten,
>
> I think the original problem is in the defcustom specification:
>
> org-capture.el L292
>
> 	   (choice :tag "Template"
> 		   (string)
> 		   (list :tag "File"
> 			 (const :format "" file)
> 			 (file :tag "Template file"))
> 		   (list :tag "Function"
> 			 (const :format "" function)
> 			 (file :tag "Template function")))
>
> The last line should read 'sexp' instead of 'file'. This is why the
> function is being held as a string.

Indeed, thanks.

- Carsten

>
> Saludos,
> .j.
>
> On Mon, Jul 19, 2010 at 09:05:06AM +0200, Carsten Dominik wrote:
>> the function must be a symbol in this setup, not a string.
>> I am rejecting this patch.
>>
>> On Jul 19, 2010, at 3:45 AM, Juan Pechiar wrote:
>
>>> Below is a patch for org-capture when the template is given by a  
>>> LISP
>>> function.
>>>
>>> Problem was that the function is inside a string (not a LISP  
>>> form), so
>>> the string has to be evaluated explicitly.

- Carsten